mirror of
https://github.com/usememos/memos.git
synced 2026-11-20 19:09:09 +01:00
7cb288864b
The instance-wide maximum upload size in the storage setting and the per-user UPLOAD_BYTES usage limit were two caps on the same thing, with a rule that the per-user value could only lower the instance value. The storage setting field is removed, and the all-users UPLOAD_BYTES usage limit is the only per-file cap. A user's own limit replaces the default in either direction, and no limit means any file size. - Remove upload_size_limit_mb from the API and store storage settings, the 32 MiB store default, and the deployment config check. - Drop the FILE_TOO_LARGE error; every refusal is QUOTA_EXCEEDED with metric UPLOAD_BYTES. - Split usagelimit.CheckFileSize out of CheckUpload and call it from memo import, so import is no longer a bypass. - Remove the Maximum upload size field from the Storage section and the instance-limit warning from the usage limits dialog. The old value is not carried over. Instances that relied on the default accept any file size until an admin sets a limit.
161 lines
6.5 KiB
Go
161 lines
6.5 KiB
Go
package test
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
"google.golang.org/protobuf/encoding/protojson"
|
|
"google.golang.org/protobuf/proto"
|
|
"google.golang.org/protobuf/types/known/fieldmaskpb"
|
|
|
|
apipb "github.com/usememos/memos/proto/gen/api"
|
|
storepb "github.com/usememos/memos/proto/gen/store"
|
|
)
|
|
|
|
func TestDeploymentConfiguredResourcesRejectMutations(t *testing.T) {
|
|
ctx := context.Background()
|
|
ts := NewTestService(t)
|
|
defer ts.Cleanup()
|
|
admin, err := ts.CreateHostUser(ctx, "admin")
|
|
require.NoError(t, err)
|
|
adminCtx := ts.CreateUserContext(ctx, admin.ID)
|
|
|
|
dir := t.TempDir()
|
|
writeDeploymentProto(t, filepath.Join(dir, "memos-idp-primary.json"), testStoreIdentityProvider("primary-sso"))
|
|
writeDeploymentProto(t, filepath.Join(dir, "memos-instance-setting-general.json"), &storepb.InstanceSetting{
|
|
Key: storepb.InstanceSettingKey_GENERAL,
|
|
Value: &storepb.InstanceSetting_GeneralSetting{GeneralSetting: &storepb.InstanceGeneralSetting{WeekStartDayOffset: 1}},
|
|
})
|
|
writeDeploymentProto(t, filepath.Join(dir, "memos-instance-setting-storage.json"), &storepb.InstanceSetting{
|
|
Key: storepb.InstanceSettingKey_STORAGE,
|
|
Value: &storepb.InstanceSetting_StorageSetting{StorageSetting: &storepb.InstanceStorageSetting{
|
|
StorageType: storepb.InstanceStorageSetting_LOCAL,
|
|
}},
|
|
})
|
|
require.NoError(t, ts.Store.LoadDeploymentConfigurationDir(ctx, dir))
|
|
|
|
providers, err := ts.Service.ListIdentityProviders(ctx, &apipb.ListIdentityProvidersRequest{})
|
|
require.NoError(t, err)
|
|
require.Len(t, providers.IdentityProviders, 1)
|
|
require.Equal(t, "Primary SSO", providers.IdentityProviders[0].Title)
|
|
|
|
setting, err := ts.Service.GetInstanceSetting(ctx, &apipb.GetInstanceSettingRequest{Name: "instance/settings/GENERAL"})
|
|
require.NoError(t, err)
|
|
require.Equal(t, int32(1), setting.GetGeneralSetting().WeekStartDayOffset)
|
|
storageSetting, err := ts.Service.GetInstanceSetting(adminCtx, &apipb.GetInstanceSettingRequest{Name: "instance/settings/STORAGE"})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "assets/{timestamp}_{uuid}_{filename}", storageSetting.GetStorageSetting().FilepathTemplate)
|
|
|
|
_, err = ts.Service.CreateIdentityProvider(adminCtx, &apipb.CreateIdentityProviderRequest{
|
|
IdentityProviderId: "primary-sso",
|
|
IdentityProvider: testAPIIdentityProvider("Replacement"),
|
|
})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
|
|
_, err = ts.Service.UpdateIdentityProvider(adminCtx, &apipb.UpdateIdentityProviderRequest{
|
|
IdentityProvider: &apipb.IdentityProvider{Name: "identity-providers/primary-sso", Title: "Changed"},
|
|
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"title"}},
|
|
})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
|
|
_, err = ts.Service.DeleteIdentityProvider(adminCtx, &apipb.DeleteIdentityProviderRequest{Name: "identity-providers/primary-sso"})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
|
|
_, err = ts.Service.UpdateInstanceSetting(adminCtx, &apipb.UpdateInstanceSettingRequest{
|
|
InstanceSetting: &apipb.InstanceSetting{
|
|
Name: "instance/settings/GENERAL",
|
|
Value: &apipb.InstanceSetting_GeneralSetting_{GeneralSetting: &apipb.InstanceSetting_GeneralSetting{}},
|
|
},
|
|
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"general_setting"}},
|
|
})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
}
|
|
|
|
func TestAuthenticationMutationAPIRejectsLockout(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
t.Run("GENERAL update requires an effective identity provider", func(t *testing.T) {
|
|
ts := NewTestService(t)
|
|
defer ts.Cleanup()
|
|
admin, err := ts.CreateHostUser(ctx, "admin")
|
|
require.NoError(t, err)
|
|
adminCtx := ts.CreateUserContext(ctx, admin.ID)
|
|
|
|
_, err = ts.Service.UpdateInstanceSetting(adminCtx, &apipb.UpdateInstanceSettingRequest{InstanceSetting: &apipb.InstanceSetting{
|
|
Name: "instance/settings/GENERAL",
|
|
Value: &apipb.InstanceSetting_GeneralSetting_{GeneralSetting: &apipb.InstanceSetting_GeneralSetting{
|
|
DisallowPasswordAuth: true,
|
|
}},
|
|
}})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
})
|
|
|
|
t.Run("last IdP cannot be deleted while regular password auth is disabled", func(t *testing.T) {
|
|
ts := NewTestService(t)
|
|
defer ts.Cleanup()
|
|
admin, err := ts.CreateHostUser(ctx, "admin")
|
|
require.NoError(t, err)
|
|
adminCtx := ts.CreateUserContext(ctx, admin.ID)
|
|
created, err := ts.Service.CreateIdentityProvider(adminCtx, &apipb.CreateIdentityProviderRequest{
|
|
IdentityProviderId: "primary-sso",
|
|
IdentityProvider: testAPIIdentityProvider("Primary"),
|
|
})
|
|
require.NoError(t, err)
|
|
_, err = ts.Service.UpdateInstanceSetting(adminCtx, &apipb.UpdateInstanceSettingRequest{InstanceSetting: &apipb.InstanceSetting{
|
|
Name: "instance/settings/GENERAL",
|
|
Value: &apipb.InstanceSetting_GeneralSetting_{GeneralSetting: &apipb.InstanceSetting_GeneralSetting{
|
|
DisallowPasswordAuth: true,
|
|
}},
|
|
}})
|
|
require.NoError(t, err)
|
|
|
|
_, err = ts.Service.DeleteIdentityProvider(adminCtx, &apipb.DeleteIdentityProviderRequest{Name: created.Name})
|
|
require.Equal(t, codes.FailedPrecondition, status.Code(err))
|
|
})
|
|
}
|
|
|
|
func testStoreIdentityProvider(uid string) *storepb.IdentityProvider {
|
|
return &storepb.IdentityProvider{
|
|
Uid: uid,
|
|
Name: "Primary SSO",
|
|
Type: storepb.IdentityProvider_OAUTH2,
|
|
Config: &storepb.IdentityProviderConfig{Config: &storepb.IdentityProviderConfig_Oauth2Config{Oauth2Config: &storepb.OAuth2Config{
|
|
ClientId: "client-id",
|
|
ClientSecret: "client-secret",
|
|
AuthUrl: "https://example.com/authorize",
|
|
TokenUrl: "https://example.com/token",
|
|
UserInfoUrl: "https://example.com/userinfo",
|
|
Scopes: []string{"openid", "profile"},
|
|
FieldMapping: &storepb.FieldMapping{Identifier: "sub"},
|
|
}}},
|
|
}
|
|
}
|
|
|
|
func testAPIIdentityProvider(title string) *apipb.IdentityProvider {
|
|
return &apipb.IdentityProvider{
|
|
Title: title,
|
|
Type: apipb.IdentityProvider_OAUTH2,
|
|
Config: &apipb.IdentityProviderConfig{Config: &apipb.IdentityProviderConfig_Oauth2Config{Oauth2Config: &apipb.OAuth2Config{
|
|
ClientId: "client-id",
|
|
ClientSecret: "client-secret",
|
|
AuthUrl: "https://example.com/authorize",
|
|
TokenUrl: "https://example.com/token",
|
|
UserInfoUrl: "https://example.com/userinfo",
|
|
Scopes: []string{"openid", "profile"},
|
|
FieldMapping: &apipb.FieldMapping{Identifier: "sub"},
|
|
}}},
|
|
}
|
|
}
|
|
|
|
func writeDeploymentProto(t *testing.T, path string, message proto.Message) {
|
|
t.Helper()
|
|
content, err := (protojson.MarshalOptions{Indent: " "}).Marshal(message)
|
|
require.NoError(t, err)
|
|
require.NoError(t, os.WriteFile(path, content, 0600))
|
|
}
|