diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 33ba105dec0..39d610a2e8e 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -623,32 +623,6 @@ jobs: run: | rm -rf ./../.cargo timeout-minutes: 60 - build_visual_tests_binary: - needs: - - orchestrate - - check_style - if: needs.orchestrate.outputs.run_tests == 'true' && github.event_name != 'merge_group' - runs-on: namespace-profile-mac-small - steps: - - name: steps::checkout_repo - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd - with: - clean: false - - name: steps::setup_cargo_config - run: | - mkdir -p ./../.cargo - cp ./.cargo/ci-config.toml ./../.cargo/config.toml - - name: steps::cache_rust_dependencies_namespace - uses: namespacelabs/nscloud-cache-action@a90bb5d4b27522ce881c6e98eebd7d7e6d1653f9 - with: - cache: rust - path: ~/.rustup - - name: run_tests::build_visual_tests_binary::cargo_build_visual_tests - run: cargo build -p zed --bin zed_visual_test_runner --features visual-tests - - name: steps::cleanup_cargo_config - if: always() - run: | - rm -rf ./../.cargo check_wasm: needs: - orchestrate @@ -1044,7 +1018,6 @@ jobs: - miri_scheduler - doctests - check_workspace_binaries - - build_visual_tests_binary - check_wasm - check_dependencies - check_docs @@ -1079,7 +1052,6 @@ jobs: check_result "miri_scheduler" "$RESULT_MIRI_SCHEDULER" check_result "doctests" "$RESULT_DOCTESTS" check_result "check_workspace_binaries" "$RESULT_CHECK_WORKSPACE_BINARIES" - check_result "build_visual_tests_binary" "$RESULT_BUILD_VISUAL_TESTS_BINARY" check_result "check_wasm" "$RESULT_CHECK_WASM" check_result "check_dependencies" "$RESULT_CHECK_DEPENDENCIES" check_result "check_docs" "$RESULT_CHECK_DOCS" @@ -1104,7 +1076,6 @@ jobs: RESULT_MIRI_SCHEDULER: ${{ needs.miri_scheduler.result }} RESULT_DOCTESTS: ${{ needs.doctests.result }} RESULT_CHECK_WORKSPACE_BINARIES: ${{ needs.check_workspace_binaries.result }} - RESULT_BUILD_VISUAL_TESTS_BINARY: ${{ needs.build_visual_tests_binary.result }} RESULT_CHECK_WASM: ${{ needs.check_wasm.result }} RESULT_CHECK_DEPENDENCIES: ${{ needs.check_dependencies.result }} RESULT_CHECK_DOCS: ${{ needs.check_docs.result }} diff --git a/tooling/xtask/src/tasks/workflows/run_tests.rs b/tooling/xtask/src/tasks/workflows/run_tests.rs index ca9c87c3d09..c59c23a6896 100644 --- a/tooling/xtask/src/tasks/workflows/run_tests.rs +++ b/tooling/xtask/src/tasks/workflows/run_tests.rs @@ -82,9 +82,6 @@ pub(crate) fn run_tests() -> Workflow { should_run_tests .and_not_in_merge_queue() .then(check_workspace_binaries()), - should_run_tests - .and_not_in_merge_queue() - .then(build_visual_tests_binary()), should_run_tests.and_not_in_merge_queue().then(check_wasm()), should_run_tests.and_always().then(check_dependencies()), // could be more specific here? should_check_docs @@ -734,22 +731,6 @@ fn run_platform_tests_impl(platform: Platform, filter_packages: bool, harden: bo } } -fn build_visual_tests_binary() -> NamedJob { - pub fn cargo_build_visual_tests() -> Step { - named::bash("cargo build -p zed --bin zed_visual_test_runner --features visual-tests") - } - - named::job( - Job::default() - .runs_on(runners::MAC_SMALL) - .add_step(steps::checkout_repo()) - .add_step(steps::setup_cargo_config(Platform::Mac)) - .add_step(steps::cache_rust_dependencies_namespace()) - .add_step(cargo_build_visual_tests()) - .add_step(steps::cleanup_cargo_config(Platform::Mac)), - ) -} - pub(crate) fn check_postgres_and_protobuf_migrations() -> NamedJob { fn ensure_fresh_merge() -> Step { named::bash(indoc::indoc! {r#"