Commit Graph

904 Commits

Author SHA1 Message Date
Lena 99dd426cba Highlight high-merge-rate authors on the community PRs board (#67038)
Pull in the list of authors with high clean merge rates from Snowflake
(clean merge rate means we are not counting a quick self-closed PR
mistake as a rejected PR), store the list in the GitHub project board's
readme (it's a hacky place, for simplicity), and show those authors as
"High MR" (not just "Returning") on the board with the community PRs.

Release Notes:

- N/A
2026-11-16 12:54:14 +00:00
Sha1rholder a57e2fdc38 Unifying agent instructions to AGENTS.md (#66716)
## Summary

Closes #66715

It's a follow-up of #45939

## Testing

This PR includes two commits. The first commit only removes CLAUDE.md
and GEMINI.md, and the second involves changes to
[dangerfile.ts](https://github.com/zed-industries/zed/blob/main/script/danger/dangerfile.ts).

Reset the second if not favored.

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- N/A

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
2026-11-16 06:53:33 +00:00
Cole Miller a19e19440d Add a backup Ubuntu package mirror in CI (#66841)
## Summary

Add the Clarkson Ubuntu mirror fallback used by Delta, restricted to
GitHub Actions. Append it to existing Namespace archive and security
mirror lists before installing Linux dependencies.

This intentionally does not rewrite direct source URLs. CI will test
whether the existing runner configuration is sufficient. Local developer
runs remain unchanged.

## Validation

- `bash -n script/linux`
- `git diff --check`
- Real-runner dependency installation is being checked by PR CI.

Release Notes:

- N/A
2026-11-11 16:08:47 +00:00
Lena 8b31ad99b8 Adjust triage-queue board automation: no 1st line (#66783)
Release Notes:

- N/A
2026-11-10 12:52:57 +00:00
Anthony Eid 4ce4b7b567 gpui: Move a Div's Interactivity out of line (#66719)
## Summary

Tessellating vector paths dominates the randomized element tree's
frames, hiding layout and the rest of the frame. This adds a
`with_paths(false)` option (the canvas stays, so layout is unchanged),
`PathlessTree/full refresh` and `PathlessTree/element style` benchmark
groups, and adds the path-free full refresh to
`script/gpui-bench-compare`'s core suite.

It also adds a random text mutation to the randomized element tree, so
its tests cover text whose measured size changes (including text that
wraps and text that's removed). Generated trees are unchanged, but the
extra mutation kind changes which mutations each seed applies.

These PRs are stacked on this one and use its path-free groups for their
benchmark numbers:

- #66723 gpui: Move a Div's Interactivity out of line (merged into this
branch)
- #66720 gpui: Only take a line wrapper when truncating text
- #66721 gpui: Compute tab stop order only when moving focus
- #66722 gpui: Trim per-line and per-glyph work in the text system

Release Notes:

- N/A
- [GPUI] Improve randomize element tree test
2026-11-09 04:15:58 +00:00
Lena 4c90ed88c3 Add more fields to the community PR board (#66617)
- Last push: the head commit's committer date, which moves with rebases
and merges from `main`.
- Merge conflicts
- Opened with no self-review: that's the `no self-review` label.

The Upvotes field now also counts comments and reviews too (and still
deduplicates per person).

The daily refresh had hit its 15-minute timeout many times so it now
fetches board items in batches of 10 (one at a time if a batch fails),
writes only values that changed, asks GitHub again for mergeability it
hasn't computed yet, and fails the run if any PR failed instead of
exiting successfully.

In `github_helpers.py`, `set_github_project_field` now handles number,
date and text fields, clears a field for `None` and can skip missing
fields. `is_staff_member` reads the staff team once per run. Requests
share one HTTP session. Rate-limited requests are retried, writes
included, as are project field writes that hit transient errors.

The refresh workflow is renamed to "Community PR Board Signals Refresh"
(also in the Slack failure notifier) for moar consistency, and it gets
members:read for the staff list.

## Testing

Ran from my machine and it worked (after two fix-ups)

Release Notes:

- N/A
2026-11-06 14:32:34 +00:00
Anthony Eid 26abd1c959 gpui_platform: Extend benchmarks and add a two-revision comparison script (#66316)
Extends the GPUI benchmarks in `gpui_platform` and adds
`script/gpui-bench-compare` for quick before/after comparisons. No
runtime behavior changes. The only new GPUI APIs are
`bench-support`-only: `Window::rendered_scene()` and
`BenchWindowContext::simulate_resize`.

## Benchmarks

- **`RandomizedTree/mixed` and `CachedTree/mixed`:** the general
benchmark. Each iteration applies a fixed, seeded sequence of changes to
a freshly built tree, one per frame: restyles, resizes, structural
edits, reorders, pointer moves, scroll events, focus moves and window
resizes, while some entities animate. Every iteration does exactly the
same work.
- **Single-change groups:** element style, leaf bounds, root layout,
insert/remove, reorder and hover. They explain where a difference in the
mixed workload comes from.
- **`CachedTree`:** the same workloads with entities wrapped in
`.cached()`.
- **`TextPanels`, `Scroll` and `LayoutChurn`:** text updates and first
frames, three scrolling workloads, and entity/ID/text churn.
`LayoutChurn` also prints a heap check before timing.
- **`Primitives`:** seeded random quads, shadows, underlines, paths and
text, plus fixed overlap patterns, painted through a window and directly
on `Scene`.
- **The randomized tree fixture:** now draws paths, shadows, scroll
containers, text, hover styles and optional animations.

The benchmarks don't check their output; that's left to the fixture's
tests. On macOS and Linux, frames include GPU submission through the
headless renderer. Text benchmarks are skipped on Windows and on macOS
without `font-kit`, because neither has a real headless text system.

## Comparison script

`script/gpui-bench-compare BASE NEW` builds both revisions once and
alternates short runs of 25 core cases. It reports foreground
instructions per frame, wall time and run-to-run spread, in about 3
minutes. It also accepts `--filter`, `--full`, `--repetitions` and
`--slow`. Both revisions must include this PR.

## Validation

- A/A runs: within ±0.15% on the mixed cases and ±0.34% or better on the
core suite.
- All 193 `--test` cases pass (`SEED=0 ITERATIONS=1`,
`bench-support,font-kit,inspector`).
- The fixture's tests and `./script/clippy` pass.
- A full `cargo bench` takes about 13 minutes on an M-series Mac. I
haven't run it on Linux.

## Follow-ups

- Add hiding the root to `CachedTree/mixed` once the `.cached()`
visibility bug is fixed.
- Add text edits, keyboard input, scale changes, overlays, virtual
lists, images and drag and drop to the mixed workload.
- Add images and SVG icons to the `Primitives` random case.
- Measure GPU time, memory and upload bandwidth next to CPU
instructions.
- Cover hover and animation in the fixture's render-equivalence test.
- Bring the window-painted `Primitives` random case into the core suite
once GPU noise is separated out.

Release Notes:

- [GPUI] Added a mixed-workload benchmark, plus cached-view, hover,
text, scrolling, layout-churn and primitive benchmarks, and
`script/gpui-bench-compare` for quick instruction-count comparisons
between two revisions
2026-11-02 02:46:28 +00:00
Lukas Wirth 2c2f737ab2 gpui: Add sendable foreground execution for web HTTP clients (#66165)
## Summary

This cleans up the gpui_platform code a bit, and in combination the way
we set up the http client for the web. This does introduce a
`ForegroundExecutor` variant that it itself is Send-able, allowing to
dispatch foreground futures from background workers (by requiring the
future to be Send, unlike `ForegroundExecutor`), which is a requirement
for web fetch.

a31c7b54c60738b82524e4e4c12aec2f6caf101d fixes a bunch of warnings with
our binary names

Release Notes:

- [gpui] N/A
2026-10-29 09:12:10 +00:00
Kirill Bulatov f14592c4a5 Require macOS 12 and SDK 26 (#65994)
Closes https://github.com/zed-industries/zed/issues/9307

Use SDK 26 and require newer macOS.
The latter allows to remove a few deprecated API usages.

Release Notes:

- [GPUI] BREAKING: bumped minimum macOS version to 12 (Monterey)
2026-10-26 11:20:07 +00:00
Finn Evers 4f862ffbc6 Cleanup unused workflows and script files (#66024)
Removes a lot of dead code we have floating around here that is no
longer used and has not been for ages.

If we ever need to check something out here again, we can just revert
parts of these. Currently, these just trigger security warnings if
anything and thus are dead weight. Hence removing here.

Drive-by fix of our collab staging deploys as well.

Release Notes:

- N/A
2026-10-23 09:30:55 +00:00
Jakub Konka 544780422a Add an HTTP fallback for the Ubuntu toolchain PPA (#65944)
## Summary

Add an HTTP fallback for the Ubuntu toolchain PPA used by `script/linux`
on Ubuntu 20.04.

The [Linux ARM64 release
job](https://github.com/zed-industries/zed/actions/runs/39623264964/job/119388744726)
failed because Launchpad's HTTPS frontend returned HTTP 503 for package
downloads. The official HTTP endpoints served the same packages
successfully.

Use APT's native `mirror+file` transport with explicit priorities:
prefer Canonical's HTTPS endpoint, and use Canonical's HTTP endpoint
only when a fetch fails. This handles both repository indexes and
package archives without custom retry logic. Other repositories and
distro setup paths are unchanged.

## Security tradeoff

This is an accepted availability workaround, not a security-equivalent
replacement for HTTPS. The signing key is still fetched over HTTPS, and
APT signature and package-hash verification remain enabled. HTTP
fallback permits network observers to see requests and attackers to
replay or freeze previously signed repository contents. This PPA has no
`Valid-Until` field. It does not permit arbitrary package modification
without a verification failure.

## Testing

- `bash -n script/linux` — passed.
- `nix shell nixpkgs#shellcheck -c ./script/shellcheck-scripts error` —
passed.
- Temporary integration harness using Ubuntu 20.04 / APT 2.0.10 and a
signed local repository, exercising the mirror-generation commands
extracted from `script/linux`:
  - Healthy HTTPS serves all requests without contacting HTTP.
  - HTTP 503 on the primary repository index falls back successfully.
- HTTP 503 on a package download falls back successfully, even after
indexes were fetched over HTTPS.
  - Both endpoints failing produces a nonzero exit.
  - Tampered signed metadata is rejected.
  - Tampered package contents are rejected.
- Downloaded all seven failing ARM64 packages across Canonical's
official HTTP endpoints and verified their hashes against repository
metadata; verified the signed `InRelease` and package-index hash.
- No full dependency installation or CI rerun performed. The temporary
integration harness is not committed.

Release Notes:

- N/A
2026-10-21 19:29:22 +00:00
Lena cd1255fba1 Automate cleanup of non-responsive PRs (#65930)
Ping and (after a grace period) close the stale community PRs where
changes were requested but not addressed.
Ping and (after a grace period) close the community PRs with no
self-review.

## Testing

Ran the dry-run locally and verified every PR listed.

Release Notes:

- N/A
2026-10-21 16:33:41 +00:00
morgankrey 92447a17cc Update certifi in update_top_ranking_issues script (#65902)
This fixes a critical security alert (GHSA-6q48-6c7w-9gw2) in the helper
script that ranks top GitHub issues. The script now installs a safe
version of `certifi`.

## What changed

One entry in `script/update_top_ranking_issues/uv.lock` changed.
`certifi` moves from `2024.8.30` to `2026.10.19`. No other package
changed.

## Why it matters

`certifi` is the list of security certificates that Python trusts when
it connects to websites. Versions before `2026.10.18` still trust the
"emSign ECC Root CA - G3" certificate. Eight certificates issued under
it had their private keys stolen, and the issuer has revoked them. A
program that uses the old list can trust a fake website.

Nothing in this script asks for `certifi` directly. The `requests`
package (used to call the GitHub API) needs it. So only the lock file
changed, and `pyproject.toml` did not.

This script is a maintenance tool. It is not part of the Zed app, so Zed
users are not affected.

## Checks

- `uv lock --upgrade-package certifi` on `main`: changed only `certifi`.
- `uv run --frozen python -c "import certifi, requests"`: loads `certifi
2026.10.19` with `requests 2.34.2`.
- `uv run --frozen python main.py --help`: runs.
- Not run: the full script. It needs a GitHub token and makes real
changes to GitHub issues.

Release Notes:

- N/A
2026-10-21 03:45:20 +00:00
Jacob Wolf 065d7ae597 agent_ui: Improve model and configuration option search (#64147)
# Objective
Fixes #64144. 

Improve search in agent model and configuration option pickers.

Previously, searches could fail when punctuation differed between the
query and model name, such as `GPT 5.6` versus `GPT-5.6`. Configuration
options also could not be found by provider/group, description, or value
identifier, and results were limited to 100 entries.

## Solution

Use the existing `fuzzy_nucleo` matcher for agent model and
configuration option searches.

Include relevant metadata in each search candidate:

- Model name and provider/group
- Configuration option name, group, description, and value identifier

Return all matching configuration options while preserving their
existing ordering when scores are equal.

Rank matches against option/model names independently of their metadata,
then append metadata-only matches without duplicates. This keeps
descriptions and identifiers searchable without letting their lengths
demote exact name matches or reorder equally relevant names.

Run the shared pure-data search pipeline on the background executor,
including candidate construction, ranking, and result cloning. This
prevents large catalogs and descriptions from monopolizing foreground
task polls without changing the ranking rule.

## Testing

- Added and ran automated tests with the following:
	- Searches with punctuation differences, such as `GPT 5.6`
	- Searches by provider/group
- Searches across configuration option names, descriptions, groups, and
identifiers
	- Searches returning more than 100 configuration options
	- Existing fuzzy-match ordering behavior
- Exact option-name matches ahead of partial-name and metadata-only
matches
	- Stable name ordering despite different metadata lengths
	- Combined queries spanning names and metadata

Follow-up validation on the ranking fix:

- `cargo test -p agent_ui --lib`: all 521 tests passed. Both new
configuration-option ranking regression tests failed before the fix and
passed afterward.
- `./script/clippy -p agent_ui`: passed, including the available
cargo-shear and typo checks.
- `rustfmt --check --edition 2024 crates/agent_ui/src/config_options.rs
crates/agent_ui/src/model_selector.rs`: passed.
- `git diff --check`: passed.

Additionally compiled the app with `cargo run`, launched OpenCode agent
in ACP mode, and searched `GPT 5.6`, which produces `OpenAI/GPT-5.6 Sol`
and `OpenRouter/GPT-5.6 Sol`. See video below.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

## Background-search validation

- `cargo test -p agent_ui --lib`: all 522 tests passed. The new
background-preparation test failed on the foreground implementation and
now passes across 20 scheduler seeds.
- `./script/clippy -p agent_ui -p agent_ui_benchmarks`: passed,
including cargo-shear and typo checks.
- `cargo fmt -p agent_ui -p agent_ui_benchmarks --check`, `git diff
--check`, and `./script/check-licenses`: passed.
- `./script/bench-agent-model-search --test`: all 20 workloads passed
before and after the change. The runner rejects any `test-support`
feature in the benchmark package graph.
- Ran quick mode before measured runs. Recorded `--save-baseline
foreground-preparation` on `b6157587dbfe96`, then ran the identical
benchmark with `--baseline foreground-preparation` on `4617d47567401e`.

Apple Silicon, Rust 1.98.1, `release-fast`, 15 Criterion samples, 200 ms
warm-up, 500 ms measurement. Representative broad-query results:

| Synthetic catalog | Total completion before → after | Foreground
task-poll p95 before → after |
| --- | --- | --- |
| 10,000 options, 128-byte descriptions | 10.35 → 12.49 ms | 7.36 → 0.46
ms |
| 10,000 options, 1,024-byte descriptions | 42.16 → 43.95 ms | 30.26 →
0.66 ms |

For the larger-description workload, foreground p99/max fell from
33.10/33.10 ms to 1.35/1.35 ms. Median foreground instructions fell from
879.9 million to 11.8 million, while total instructions stayed
approximately 2.14 billion. Observed synthetic 120 FPS budget overruns
fell from 66 to zero for this workload.

This improves foreground responsiveness rather than reducing total work.
Other Rust builds were active on the machine, so completion-time
estimates are noisy and no throughput speedup is claimed. The benchmark
measures the production search module with synthetic ACP-like options,
not provider requests, picker rendering, or live keystrokes. Its
foreground report includes warm-up/calibration, and budget overruns are
not literal display-dropped frames.

## Showcase


https://github.com/user-attachments/assets/04c1a59e-8454-49f8-af6c-47e1107f9416

---

Release Notes:

- Improved fuzzy searching for agent model and configuration option
pickers across Zed Agent and third-party ACP-compatible agents,
preserving name relevance and keeping search preparation off the UI
thread.

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2026-10-20 13:06:38 +00:00
Sniffy Gumbles 18787a9a08 Add llvm to Arch dependencies in script/linux (#65462)
## Summary

Arch build needs llvm package for llvm-objcopy commands in
script/bundle-linux

## Testing

Ran full build/install using script/install-linux

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [X] Tests cover the new or changed behavior.

Release Notes:

- N/A
2026-10-13 23:07:07 +00:00
Lena fa1b94c6b9 Post a comment on first-timers' pull requests (#65390)
A short summary of the most relevant parts of CONTRIBUTING.md and the
link to the full guidelines.

Release Notes:

- N/A
2026-10-12 10:58:42 +00:00
Kirill Bulatov 976ab33fb4 Reduce release binary sizes (#65168)
Not sure how worth such optimization is WRT the speed, but for such
gains, seems worth opening to discuss?

-----------

Optimize selected workspace crates for size and hide Rust exports in
macOS bundles.

Measurements (release editor executable size):

| Platform | Architecture | Before (bytes) | After (bytes) | Reduction
(bytes / %) |
| --- | --- | ---: | ---: | ---: |
| macOS | ARM64 | 258,218,240 | 172,524,896 | 85,693,344 / 33.19% |
| Linux | x86_64 | 317,435,136 | 295,344,952 | 22,090,184 / 6.96% |
| Windows | x86_64 | 358,987,776 | 256,678,400 | 102,309,376 / 28.50% |


Release Notes:

- Reduced Zed's binary size
2026-10-07 14:56:09 +00:00
Lena 2a4326a256 Duplicate Bot tracking: handle issues deleted mid-run (#65222)
Release Notes:

- N/A
2026-10-06 09:03:03 +00:00
Lena 24aabd3fa6 Community board automations: ignore case for Track (#65224)
This is only really needed for Track, a custom field that has a
manually-maintained mapping to the area labels on PRs, but it's a cheap
enough operation for the rest of them. Follow-up to
https://github.com/zed-industries/zed/pull/64650

Release Notes:

- N/A
2026-10-06 09:03:01 +00:00
Kirill Bulatov 204362325c Fix incorrect LLD used when bundling (#65183)
Follow-up to https://github.com/zed-industries/zed/pull/65169
Fixes
https://github.com/zed-industries/zed/actions/runs/37313460920/job/111774290269#logs

Release Notes:

- N/A
2026-10-05 15:03:19 +00:00
Kirill Bulatov d6b7f24b7b Improve Linux binary size (#65169)
First commit enables safe identical-code folding and strip unneeded
Linux symbols.

Measurements (release editor executable size, made after
https://github.com/zed-industries/zed/pull/65168):

Baseline includes the workspace size optimizations in
kb/binary-size-again-1.

| Platform | Architecture | Before (bytes) | After (bytes) | Reduction
(bytes / %) |
| --- | --- | ---: | ---: | ---: |
| Linux | x86_64 | 295,344,952 | 225,907,112 | 69,437,840 / 23.51% |

Second commit ensures the symbols are always uploaded to Sentry.

Release Notes:

- Improved Linux binary size
2026-10-05 11:51:47 +00:00
renovate[bot] ba2b48461d Update dependency urllib3 to v2.8.0 [SECURITY] (#64995)
This PR contains the following updates:

| Package | Change |
[Age](https://docs.renovatebot.com/merge-confidence/) |
[Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [urllib3](https://redirect.github.com/urllib3/urllib3)
([changelog](https://redirect.github.com/urllib3/urllib3/blob/main/CHANGES.rst))
| `2.7.0` → `2.8.0` |
![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/2.8.0?slim=true)
|
![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/2.7.0/2.8.0?slim=true)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency
Dashboard](../issues/15138) for more information.

---

### urllib3: HTTPS proxy TLS configuration may be ignored or overridden
[CVE-2026-97687](https://nvd.nist.gov/vuln/detail/CVE-2026-97687) /
[GHSA-8988-9cw3-xx77](https://redirect.github.com/advisories/GHSA-8988-9cw3-xx77)

<details>
<summary>More information</summary>

#### Details
##### Impact

urllib3 supports configuring TLS independently for an HTTPS proxy and
the target server.

`proxy_ssl_context`, `proxy_assert_hostname`, and
`proxy_assert_fingerprint` configure the TLS connection to the proxy.
`ssl_context` and the other target-specific TLS parameters configure the
connection to the target server.

In urllib3 versions 1.26.0 through 2.7.0, these configurations were not
consistently separated. Depending on the proxy mode, urllib3 could:

1. Ignore `proxy_ssl_context` and use the target server's SSL context
for the TLS connection to an HTTPS forwarding proxy.
2. Override the HTTPS proxy's certificate-verification policy with the
target server's certificate-verification policy.
3. Apply target-specific SNI, hostname assertions, certificate
fingerprint assertions, or TLS client credentials to the TLS connection
to an HTTPS forwarding proxy.

In particular, configuring `cert_reqs="CERT_NONE"` for a target server
could overwrite the `verify_mode` of the SSL context configured for the
HTTPS proxy. This modification occurred in place and persisted on the
context object, potentially disabling proxy certificate verification for
later connections that reused the same context.

An attacker able to intercept the connection to an HTTPS proxy may be
able to impersonate the proxy when the effective proxy TLS configuration
disables certificate verification or otherwise accepts the attacker's
certificate. This may occur, for example, when the target server's trust
or identity policy is incorrectly applied to the proxy connection.

When HTTPS forwarding is enabled, an impersonated proxy can observe or
modify forwarded requests and responses, potentially exposing
credentials, authentication tokens, request bodies, response data, and
other sensitive information.

A TLS client certificate intended for the target server may also be
presented to the proxy or to an attacker impersonating it. This can
disclose the client's identity and provide proof of possession of the
corresponding private key. The private key itself is not transmitted
during the TLS handshake.

In CONNECT tunneling mode, impersonating the HTTPS proxy does not by
itself defeat the separate end-to-end TLS connection between the client
and the target server.

##### Affected Usages

Code using urllib3 versions 1.26.0 through 2.7.0 may be affected in any
of the following cases.

##### 1. The target SSL context is used for an HTTPS forwarding proxy

HTTPS requests are forwarded through an HTTPS proxy with
`use_forwarding_for_https=True`, and `proxy_ssl_context` is configured
for the proxy.

urllib3 may ignore `proxy_ssl_context` and use the target server's
`ssl_context` for the proxy TLS handshake. The proxy may therefore be
verified using the target server's trust and certificate policy instead
of the policy explicitly configured for the proxy.

##### 2. The target verification policy overrides the proxy policy

An HTTPS proxy is configured with `proxy_ssl_context`, while the target
server uses a different certificate-verification policy.

urllib3 may apply the target server's `cert_reqs` value to the proxy SSL
context. For example, setting `cert_reqs="CERT_NONE"` for the target
server may also disable certificate verification for the HTTPS proxy,
even when `proxy_ssl_context` was configured to require verification.

This issue can affect the TLS connection to an HTTPS proxy in both
forwarding and CONNECT tunneling configurations.

##### 3. A mutated proxy SSL context is reused

The same SSL context is reused as `proxy_ssl_context` across multiple
connections, and certificate verification is disabled for one target
server.

urllib3 may modify the proxy SSL context's `verify_mode` in place. Later
connections that reuse the same context may therefore connect to the
HTTPS proxy without certificate verification.

##### 4. Target-specific TLS identity or credentials are applied to the
proxy

HTTPS requests are forwarded through an HTTPS proxy with
`use_forwarding_for_https=True`, and target-specific SNI, hostname
assertions, certificate fingerprint assertions, or TLS client
credentials are configured.

urllib3 may apply these target-specific settings to the proxy TLS
handshake. This may cause urllib3 to:

- send SNI intended for the target server to the proxy;
- verify the proxy using a hostname or certificate fingerprint intended
for the target server; or
- present a TLS client certificate intended for the target server to the
proxy.

Code connecting through a plain HTTP proxy does not establish a TLS
connection to the proxy and is not affected by this issue.

##### Remediation

Upgrade to urllib3 2.8.0 or later.

urllib3 2.8.0 independently applies the explicitly configured
`proxy_ssl_context` and proxy-specific certificate assertions to the
HTTPS proxy connection. Target-specific SNI, certificate assertions, and
TLS client certificate parameters are no longer applied to the HTTPS
proxy handshake.

For backward compatibility, when an HTTPS proxy is used with
`use_forwarding_for_https=True` and `proxy_ssl_context` is not provided,
urllib3 2.8.0 continues to use `ssl_context` for the TLS connection to
the proxy. This configuration emits a `FutureWarning`. In urllib3 3.0,
passing `ssl_context` with `use_forwarding_for_https=True` for an HTTPS
proxy will raise an error. Applications should use `proxy_ssl_context`
to configure TLS for an HTTPS forwarding proxy.

The fixes were implemented in commits
b6447295fff7b38fdffc67e0df9712d60cef3cc3 and
07408cec79d1856d81bb42c74a904a24fdb9e465.

#### Severity
- CVSS Score: 7.6 / 10 (High)
- Vector String:
`CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N`

#### References
-
[https://github.com/urllib3/urllib3/security/advisories/GHSA-8988-9cw3-xx77](https://redirect.github.com/urllib3/urllib3/security/advisories/GHSA-8988-9cw3-xx77)
-
[https://nvd.nist.gov/vuln/detail/CVE-2026-97687](https://nvd.nist.gov/vuln/detail/CVE-2026-97687)
-
[https://github.com/urllib3/urllib3/pull/5093](https://redirect.github.com/urllib3/urllib3/pull/5093)
-
[https://github.com/urllib3/urllib3/commit/07408cec79d1856d81bb42c74a904a24fdb9e465](https://redirect.github.com/urllib3/urllib3/commit/07408cec79d1856d81bb42c74a904a24fdb9e465)
-
[https://github.com/urllib3/urllib3/commit/b6447295fff7b38fdffc67e0df9712d60cef3cc3](https://redirect.github.com/urllib3/urllib3/commit/b6447295fff7b38fdffc67e0df9712d60cef3cc3)
-
[https://github.com/urllib3/urllib3/releases/tag/2.8.0](https://redirect.github.com/urllib3/urllib3/releases/tag/2.8.0)
-
[https://github.com/advisories/GHSA-8988-9cw3-xx77](https://redirect.github.com/advisories/GHSA-8988-9cw3-xx77)

This data is provided by the [GitHub Advisory
Database](https://redirect.github.com/advisories/GHSA-8988-9cw3-xx77)
([CC-BY
4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)).
</details>

---

### urllib3: HTTPResponse.stream()/read_chunked() buffers an unbounded
chunk-size line into memory
[CVE-2026-97689](https://nvd.nist.gov/vuln/detail/CVE-2026-97689) /
[GHSA-vxq7-64xx-v4gw](https://redirect.github.com/advisories/GHSA-vxq7-64xx-v4gw)

<details>
<summary>More information</summary>

#### Details
##### Impact

urllib3's [streaming
API](https://urllib3.readthedocs.io/en/2.7.0/advanced-usage.html#streaming-and-i-o)
is designed for efficiently handling large HTTP responses by reading the
content in chunks, rather than loading the entire response body into
memory at once. When decoding a [chunked-transfer-encoded
response](https://httpwg.org/specs/rfc9112.html#chunked.encoding), this
API reads each chunk's size field by buffering until it sees `\n` or
EOF.

A malicious HTTP server can return `Transfer-Encoding: chunked` and then
send a very long run of bytes without any newline, causing the streaming
client to buffer that entire run before urllib3 can reject the chunk
size as invalid and allocate more memory than intended.

To fix the issue, we'll reject chunk-size fields larger than 65536
bytes, as already done in the non-streaming case, which is currently
handled by the Python standard library. Note that this only applies to
reading the chunk-size field, not the chunk data, which is already
handled correctly. Thus, there shouldn't be any impact for non-malicious
servers.

##### Affected usages

Applications and libraries using urllib3 versions earlier than 2.8.0 may
be affected when streaming a chunked response from untrusted sources.
Specifically, this affects the
[read_chunked()](https://urllib3.readthedocs.io/en/stable/reference/urllib3.response.html#urllib3.response.BaseHTTPResponse.read_chunked)
and
[stream()](https://urllib3.readthedocs.io/en/stable/reference/urllib3.response.html#urllib3.response.BaseHTTPResponse.stream)
methods of the HTTPResponse object.

This also affects requests streaming API, which uses urllib3 under the
hood.

##### Remediation

Upgrade to urllib3 version 2.8.0 or later, where chunk-size fields
larger than 65536 will be rejected. If upgrading is not immediately
possible, consider reading the response at once using the
[read()](https://urllib3.readthedocs.io/en/stable/reference/urllib3.response.html#urllib3.response.BaseHTTPResponse.read)
method.

#### Severity
- CVSS Score: 8.9 / 10 (High)
- Vector String:
`CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:H`

#### References
-
[https://github.com/urllib3/urllib3/security/advisories/GHSA-vxq7-64xx-v4gw](https://redirect.github.com/urllib3/urllib3/security/advisories/GHSA-vxq7-64xx-v4gw)
-
[https://nvd.nist.gov/vuln/detail/CVE-2026-97689](https://nvd.nist.gov/vuln/detail/CVE-2026-97689)
-
[https://github.com/urllib3/urllib3/commit/cd770b059b543be29298ea5c52afb0b1b090f5ed](https://redirect.github.com/urllib3/urllib3/commit/cd770b059b543be29298ea5c52afb0b1b090f5ed)
-
[https://github.com/urllib3/urllib3/releases/tag/2.8.0](https://redirect.github.com/urllib3/urllib3/releases/tag/2.8.0)
-
[https://github.com/advisories/GHSA-vxq7-64xx-v4gw](https://redirect.github.com/advisories/GHSA-vxq7-64xx-v4gw)

This data is provided by the [GitHub Advisory
Database](https://redirect.github.com/advisories/GHSA-vxq7-64xx-v4gw)
([CC-BY
4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)).
</details>

---

### urllib3: Chunked Deflate streaming can enter an infinite loop
[CVE-2026-97688](https://nvd.nist.gov/vuln/detail/CVE-2026-97688) /
[GHSA-gh4c-6fx4-qh6g](https://redirect.github.com/advisories/GHSA-gh4c-6fx4-qh6g)

<details>
<summary>More information</summary>

#### Details
##### Impact

urllib3's streaming API is designed for the efficient handling of large
HTTP responses by reading content in chunks instead of loading the
entire response body into memory at once.

urllib3 can decompress response bodies according to the HTTP
`Content-Encoding` header. When streaming a compressed, chunked
response, urllib3 first consumes data already buffered by the decoder
before reading the next HTTP chunk.

However, urllib3 versions from 2.6.2 through 2.7.0 could enter an
infinite loop when a chunked response contained bytes after the end of
the Deflate stream. If the decompressed body exceeded the requested
streaming chunk size, Python's zlib implementation could retain the
trailing bytes as unconsumed input after reaching the end of the
compressed stream. urllib3 would repeatedly attempt to decode those same
bytes without making progress or reading more data from the network.

A malicious server could exploit this behavior to cause excessive CPU
usage and prevent the affected request from completing on the client.
Network read timeouts would not interrupt the loop because no further
socket operation was required.

##### Affected usages

Applications and libraries using urllib3 versions 2.6.2 through 2.7.0
may be affected when all of the following conditions are met:

1. Compressed responses from an untrusted source are streamed using
`HTTPResponse.stream(amt=N)` or `HTTPResponse.read_chunked(amt=N)` with
a positive, finite chunk size.
2. Content decoding is enabled.
3. The response uses both `Transfer-Encoding: chunked` and
`Content-Encoding: deflate`.
4. The decoded body exceeds the requested chunk size and the encoded
body contains bytes after the end of the Deflate stream.

`HTTPResponse.stream()` uses a finite chunk size by default and is
therefore affected when the other conditions are met.

##### Remediation

Upgrade to urllib3 2.8.0, in which the Deflate decoder stops accepting
input after reaching the end of the compressed stream and no longer
reports trailing bytes as data that can produce more decoded output.

If upgrading is not immediately possible, disable automatic content
decoding for responses from untrusted sources by setting
`decode_content=False`, or reject streamed responses using the Deflate
content encoding. Applications that disable automatic decoding must
handle the compressed response safely at another layer.

#### Severity
- CVSS Score: 6.9 / 10 (Medium)
- Vector String:
`CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N`

#### References
-
[https://github.com/urllib3/urllib3/security/advisories/GHSA-gh4c-6fx4-qh6g](https://redirect.github.com/urllib3/urllib3/security/advisories/GHSA-gh4c-6fx4-qh6g)
-
[https://nvd.nist.gov/vuln/detail/CVE-2026-97688](https://nvd.nist.gov/vuln/detail/CVE-2026-97688)
-
[https://github.com/urllib3/urllib3/commit/ea2ad7b21a80da3632f80016526a18864586077f](https://redirect.github.com/urllib3/urllib3/commit/ea2ad7b21a80da3632f80016526a18864586077f)
-
[https://github.com/urllib3/urllib3/releases/tag/2.8.0](https://redirect.github.com/urllib3/urllib3/releases/tag/2.8.0)
-
[https://github.com/advisories/GHSA-gh4c-6fx4-qh6g](https://redirect.github.com/advisories/GHSA-gh4c-6fx4-qh6g)

This data is provided by the [GitHub Advisory
Database](https://redirect.github.com/advisories/GHSA-gh4c-6fx4-qh6g)
([CC-BY
4.0](https://redirect.github.com/github/advisory-database/blob/main/LICENSE.md)).
</details>

---

### Release Notes

<details>
<summary>urllib3/urllib3 (urllib3)</summary>

###
[`v2.8.0`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#280-2026-09-15)

[Compare
Source](https://redirect.github.com/urllib3/urllib3/compare/2.7.0...2.8.0)

\==================

## Security

Fixed the following security issues:

- The TLS configuration for HTTPS proxies could be ignored or
overridden.
(High severity, `GHSA-8988-9cw3-xx77
<https://github.com/urllib3/urllib3/security/advisories/GHSA-8988-9cw3-xx77>`\_\_)
- `HTTPResponse.stream()` and `read_chunked()` could buffer a chunk-size
  line of unbounded length in memory. (High severity,
`GHSA-vxq7-64xx-v4gw
<https://github.com/urllib3/urllib3/security/advisories/GHSA-vxq7-64xx-v4gw>`\_\_)
- Chunked Deflate streaming could enter an infinite loop. (Medium
severity,
`GHSA-gh4c-6fx4-qh6g
<https://github.com/urllib3/urllib3/security/advisories/GHSA-gh4c-6fx4-qh6g>`\_\_)

.. caution::

```
urllib3 2.8.0 fixes HTTPS proxy TLS configuration being ignored or
overridden by destination settings. Configurations relying on that
behavior may require changes.

Configure proxy CA certificates and client certificates in
``proxy_ssl_context``, and proxy identity checks with
``proxy_assert_hostname`` or ``proxy_assert_fingerprint``.
Destination client certificates and identity overrides no longer
apply to HTTPS forwarding proxy connections.
```

## Deprecations & Removals

- Deprecated using an empty collection as the `Retry` option
  `allowed_methods` to retry any verb.
  (`#&#8203;5044 <https://github.com/urllib3/urllib3/issues/5044>`\_\_)

## Features

- Added `Url.auth_decoded` and `Url.auth_decoded_joined` convenience
  properties to the result of `parse_url()`.
  (`#&#8203;4945 <https://github.com/urllib3/urllib3/issues/4945>`\_\_)
- Added `basic_auth_encoding` and `proxy_basic_auth_encoding` parameters
to
  `urllib3.util.make_headers()`.
  (`#&#8203;5092 <https://github.com/urllib3/urllib3/issues/5092>`\_\_)

## Bugfixes

- Fixed response header handling to replace obsolete folded header lines
(`obs-fold`) with spaces in accordance with RFC 9112, preventing raw
CRLF
  sequences from appearing in header values such as `Set-Cookie`.
  (`#&#8203;1362 <https://github.com/urllib3/urllib3/issues/1362>`\_\_)
- Fixed usage of `proxy_ssl_context` with `ProxyManager` when
  `use_forwarding_for_https=True`. Passing `ssl_context` instead of
`proxy_ssl_context` for HTTPS proxies in this configuration now emits a
  `FutureWarning` and will raise an error in v3.0.
  (`#&#8203;2577 <https://github.com/urllib3/urllib3/issues/2577>`\_\_)
- Changed behavior of the default `ConnectionPool.pool` initialization.
  `LifoQueue` is now resolved from the `queue` module after the
  `ConnectionPool` is instantiated instead of using the default cached
  `QueueCls` class property. This is done because sometimes the
`queue.LifoQueue` is monkey-patched late in the program, such as by
gevent.
  (`#&#8203;3289 <https://github.com/urllib3/urllib3/issues/3289>`\_\_)
- Raised `UnrewindableBodyError` instead of `ValueError` when retrying a
  request whose body had `tell()` but not `seek()`.
  (`#&#8203;3779 <https://github.com/urllib3/urllib3/issues/3779>`\_\_)
- Decoded percent-encoded SOCKS proxy credentials before authenticating
with
  the proxy server.
  (`#&#8203;3785 <https://github.com/urllib3/urllib3/issues/3785>`\_\_)
- Fixed `HTTPResponse.drain_conn()` to discard unread response data in
64 KiB
chunks (same as the default `amt` when doing
`HTTPResponse.stream(...)`).
  (`#&#8203;5019 <https://github.com/urllib3/urllib3/issues/5019>`\_\_)
- Fixed `is_ipaddress()` to detect non-standard IPv4 forms accepted by
`socket.connect`, such as hex (`0x7f000001`), octal (`0177.0.0.1`), and
decimal integers (`2130706433`), ensuring SSL certificate verification
uses
  the correct mode for these addresses.
  (`#&#8203;5029 <https://github.com/urllib3/urllib3/issues/5029>`\_\_)
- Fixed `HTTPConnectionPool.urlopen` raising a misleading
`FullPoolError`
instead of `ValueError` when called with an invalid `timeout` argument
on
  a pool created with `block=True`.
  (`#&#8203;5059 <https://github.com/urllib3/urllib3/issues/5059>`\_\_)
- Fixed port-zero handling to preserve explicit `:0` values instead of
substituting the default ports 80 or 443 in URL parsing, pool selection,
proxy configuration, `connection_from_url()`, and HTTP/2 request
authority.
  (`#&#8203;5071 <https://github.com/urllib3/urllib3/issues/5071>`**,
  `#&#8203;5101 <https://github.com/urllib3/urllib3/issues/5101>`**)
- Fixed a bug where `PoolManager` passed the `assert_hostname` and
  `assert_fingerprint` parameters to HTTP connection pools.
  (`#&#8203;5077 <https://github.com/urllib3/urllib3/issues/5077>`\_\_)
- Fixed `HTTPConnectionPool.urlopen()` and HTTP proxy forwarding to
strip URL
  fragments from absolute request targets before sending requests.
  (`#&#8203;5079 <https://github.com/urllib3/urllib3/issues/5079>`\_\_)
- Added safeguards to the proxy tunneling code to prevent potential
security
issues when handling invalid characters in the proxy host and HTTP
headers.
This change affects users of Python 3.10, Python 3.11, and Python 3.12
when
the standard library does not contain the fix; those on newer Python
versions
  should upgrade to 3.13.14+ or 3.14.5+ to get the same security fixes.
  (`#&#8203;5091 <https://github.com/urllib3/urllib3/issues/5091>`\_\_)
- Fixed `HTTPSConnection.connect()` overriding
`ProxyConfig.ssl_context`'s
certificate policy and proxy identity checks with the target
connection's TLS
  settings when forwarding through an HTTPS proxy.

  `HTTPSConnection` no longer applies target SNI, assertions, or client
  credentials to forwarding proxy handshakes and continues to use its
`ssl_context` as a fallback when an HTTPS proxy forwards an HTTP target.
  (`#&#8203;5093 <https://github.com/urllib3/urllib3/issues/5093>`\_\_)
- Fixed URL parsing to more strictly enforce RFC 3986 host syntax,
rejecting
invalid host input such as raw spaces and control characters, malformed
percent-encodings, and percent-encoded control characters in HTTP(S)
hosts
and IPv6 zone identifiers, including proxy CONNECT tunnel targets. Host
  normalization now also follows RFC 3986 normalization rules for
percent-encoded octets by decoding percent-encoded unreserved characters
and
  uppercasing the hexadecimal digits of retained percent-encoded octets.
  (`#&#8203;5095 <https://github.com/urllib3/urllib3/issues/5095>`\_\_)
- Fixed an `AttributeError` on Python built with OpenSSL 4+, where
  `ssl.PROTOCOL_TLSv1` no longer exists.
  (`#&#8203;5097 <https://github.com/urllib3/urllib3/issues/5097>`\_\_)
- Fixed `urllib3.contrib.pyopenssl` to use cryptography APIs when
reading a
  certificate subject and loading encrypted private keys, avoiding
  `DeprecationWarning` raised by pyOpenSSL 26.3.0+.
  (`#&#8203;5103 <https://github.com/urllib3/urllib3/issues/5103>`\_\_)
- Fixed handling of HTTP 303 redirects for requests with chunked or
file-like
  bodies.
  (`#&#8203;5161 <https://github.com/urllib3/urllib3/issues/5161>`\_\_)
- Fixed `assert_fingerprint()` to raise `SSLError` instead of
`binascii.Error` when a fingerprint has a supported length but contains
  non-hexadecimal characters.
  (`#&#8203;5211 <https://github.com/urllib3/urllib3/issues/5211>`\_\_)

## Misc

- Added a `test` dependency group containing the minimum dependencies
needed
to run the test suite, intended for downstream packagers. The `dev-base`
  and `mypy` groups now include this new group via `include-group`,
  removing duplication.
  (`#&#8203;3594 <https://github.com/urllib3/urllib3/issues/3594>`\_\_)
- Fixed test failures with pytest >= 9.1.
  (`#&#8203;5094 <https://github.com/urllib3/urllib3/issues/5094>`\_\_)
- Enabled JSPI tests with Firefox in the Emscripten test suite.
  (`#&#8203;5166 <https://github.com/urllib3/urllib3/issues/5166>`\_\_)
- Improved streamed response decoding performance.
  (`#&#8203;5209 <https://github.com/urllib3/urllib3/issues/5209>`\_\_)
- Fixed flaky tests.
  (`#&#8203;5232 <https://github.com/urllib3/urllib3/issues/5232>`**,
  `#&#8203;5234 <https://github.com/urllib3/urllib3/issues/5234>`**,
  `#&#8203;5239 <https://github.com/urllib3/urllib3/issues/5239>`\_\_)

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/New_York)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-10-02 07:57:16 +00:00
chogng bf89346c1b Fix Auth and Zed.dev community PR routing (#64650)
## Why

The Community PR Board route check looks up the configured Track option
by exact name. The mapping for auth-related labels uses `Auth &
Zed.dev`, while the project option is `Auth & zed.dev`, so `route-pr`
fails when it handles those labels.

## What changed

Update the auth-related label mapping to use the existing `Auth &
zed.dev` Track name.

## Testing

- `python3 -m json.tool script/community-pr-track-mapping.json`
- `git diff --check`

Release Notes:

- N/A
2026-09-23 14:15:20 +00:00
Ali 62e5991dd0 Keep the grid top-anchored when growing on Windows (#63699)
# Objective
fixes https://github.com/zed-industries/zed/issues/39453.


## Solution

-  Bump bundled ConPTY to 1.25.260710002

## Testing

- 


## Showcase
before : 


https://github.com/user-attachments/assets/8d3fd721-20fb-4d9d-a468-db3e5dc7ae21


after : 


https://github.com/user-attachments/assets/af0c70ce-503b-45cd-b74b-7098f713c7d8


---

Release Notes:

- Keep the grid top-anchored when growing on Windows

---------

Co-authored-by: Finn Evers <finn.evers@outlook.de>
2026-09-22 12:38:36 +00:00
rn23thakur af431aeef4 ui: Add buttons to switch diff view when diffing buffers (#64529)
# Objective

- This PR enables users to switch between unified/split diff views when
comparing buffers.
- Fixes #64419 .

## Solution

- The unified/split toggle (`DiffStyleControls`) is normally surfaced
automatically by `BufferSearchBar`, which detects any active item
exposing a `SplittableEditor`. That auto-detection is gated to
multi-buffer views, since it's paired with an expand/collapse-all-hunks
control that only makes sense across multiple files. `FileDiffView`
(used by `zed --diff <old> <new>`) is a singleton buffer, so it's
intentionally excluded from that generic path.
- Git's own single-file diff view,
[`SoloDiffView`](https://github.com/zed-industries/zed/blob/395def7a067b32ed598fcb3f048969ada9b54942/crates/git_ui/src/solo_diff_view.rs#L52),
hits the same limitation and works around it with a small, dedicated
`ToolbarItemView` (`SoloDiffStyleToolbar`) that renders
`DiffStyleControls` directly, independent of `BufferSearchBar`.
- This PR follows the same pattern: a new `FileDiffStyleToolbar` (in
`git_ui_core::file_diff_view`) activates whenever a `FileDiffView` is
the focused pane item, and renders just the unified/split toggle, no
expand/collapse or file-status controls, since neither concept applies
to a plain two-file diff. It's registered in `initialize_pane` alongside
the existing git toolbars.


## Testing

- Did you test these changes? If so, how?
Ran `cargo test -p git_ui_core`, all passed. I've also attached the
results of manual testing in the Showcase section below.
- Are there any parts that need more testing?
I think more tests can be added.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

## Showcase

Adds a unified/split toggle to the diff view opened via `zed --diff
<old> <new>`, matching the toggle already available in git's diff views.

<details>
  <summary>Click to view before/after</summary>

**Before**:
<img width="1920" height="1080" alt="screenshot_20260921_020610"
src="https://github.com/user-attachments/assets/92cbcf75-0cac-4555-8d2d-ce927064515f"
/>

**After**:
<img width="1920" height="1080" alt="screenshot_20260921_020355"
src="https://github.com/user-attachments/assets/56f9ebc6-11df-41cc-a44d-99bfa8caa130"
/>

</details>

---

Release Notes:

- Added a unified/split toggle to the diff view opened via `zed --diff
<old> <new>` command.

---------

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
2026-09-21 11:17:46 +00:00
Hyeondong Lee 74646bf29c Fix casing of libX11-devel SUSE package in script/linux (#64411)
## Objective

`libx11-devel` is not a valid package name in SUSE: it should
be`libX11-devel` (_should be a capital X!_).

source: [RPM resource
libX11-devel](https://rpmfind.net/linux/rpm2html/search.php?query=libX11-devel)

## Testing

- [x] Did you test these changes? If so, how?
- Tested on SLES 15.7 an [openSUSE
Tumbleweed](https://software.opensuse.org/package/libX11-devel)
  - `script/bundle-linux` succeeds

<img width="675" height="175" alt="Screenshot 2026-09-18 at 02 43 41"
src="https://github.com/user-attachments/assets/4a89f6e5-de9f-4457-a6c2-8f5a15ad4283"
/>


---

Release Notes:

- N/A
2026-09-17 18:31:12 +00:00
Kirill Bulatov 9930d2c2a3 Share generics better and strip rodio audio features (#64260)
* Preserve bundle compiler flags commit commit is a follow-up to
https://github.com/zed-industries/zed/pull/63432

Linux bundling script had custom `RUSTFLAGS` set which eradicated prior
config.
Moved all flags into `.cargo/bundle-config.toml` instead.

* Trim audio features and compress resources commit removes unused
`rodio` features and enables resource compression

The win from the latter seems not that large, so can revert if needed,
but seemed very easy to enable.

With compiler wrappers disabled, `cargo clean --target-dir
target/binary-size-split-build` and `cargo build --locked -p zed`:
Before: 135.6s wall, 1569.8s CPU, zed binary 1175563800 bytes
After: 130.5s wall (-3.8%), 1488.7s CPU (-5.2%), zed binary 1171527064
bytes (-0.3%, -4.0MB)

With `ZED_BUNDLE=true CXXFLAGS=-stdlib=libc++` and `cargo --config
.cargo/bundle-config.toml build --locked --release -p zed -p cli
--target aarch64-apple-darwin`:
Before: 369.4s wall, 3861.6s CPU, zed binary 381662328 bytes
After: 369.4s wall (+0.01%), 3866.1s CPU (+0.1%), zed binary 377836968
bytes (-1.0%, -3.8MB)

Release Notes:

- N/A
2026-09-16 16:03:18 +00:00
Finn Evers 2328e18cac Move some configuration files out of the repository root (#64303)
This PR cleans up the repository root a bit, moving some of the less
relevant config files into the `.config` folder and removing unused
ones.

Release Notes:

- N/A
2026-09-16 14:08:49 +00:00
Finn Evers 93f9fce115 Require release notes to be present (#64238)
Release notes are the sole information users have about what could
either have improved or have been broken for them. Omitting release
notes is one thing, but not writing any or having empty ones helps
nobody - users get no context on what could cause issues they were
seeing nor do they know about potential improvements, triagers cannot
easily find the PR that could have introduced the bug either.

Thus, this PR now makes it so that danger actually requires one to write
release notes. Empty release notes or the placeholder will no longer be
accepted.

Release Notes:

- N/A
2026-09-15 13:38:45 +00:00
Finn Evers ee1c6f8c40 Add initial support for having GPUI release notes (#64203)
Release Notes:

- N/A
2026-09-15 12:43:19 +00:00
Kamil Jakubus a3e93fffaa extension: Bump wasi-sdk to version 34 (#63816)
# Objective

Bumps `wasi-sdk` to v34 that is based on LLVM 23.1 which includes [a
compile time and memory usage
fix](https://github.com/llvm/llvm-project/pull/181755) for tree-sitter
grammars. It speeds up every grammar's compile time and reduces compile
memory usage unlocking big grammars that were impossible to compile
before to be submitted to Zed extensions.

Drive-by added additional wasi-sdk targets for the rest of the supported
architectures (by wasi-sdk), if riscv is unwanted I can remove it but it
should not create any problems (I think).

Also noticed the `download-wasi-sdk` script had `OS=mingw` which wasn't
even in the artifact name on v25.

## Testing

Compiled, ran and compiled my [big
grammar](https://github.com/usagi-coffee/tree-sitter-abl) on it, that
wouldn't compile at all pre-llvm 23.

## Self-Review Checklist:

- [X] I've reviewed my own diff for quality, security, and reliability

---

Release Notes:

- Fixed compiling dev extensions with big Tree-sitter grammars.
- Fixed compiling dev extensions on Windows ARM64.
- Added wasi-sdk installation invalidation.

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
2026-09-09 15:16:15 +00:00
Finn Evers 6916400834 Add platform:web to community-pr-track-mapping.json (#63753)
Release Notes:

- N/A
2026-09-07 07:30:20 +00:00
Lena e2c4075cd0 Handle reopened PRs on the community PR board (#63755)
The particular edge case that is covered here is closing a community PR,
then labeling it with an `area:`, and _then_ reopening it.

Release Notes:

- N/A
2026-09-04 12:47:05 +00:00
Lena a7bc7d7736 Consolidate GitHub helpers for community scripts (#63198)
It's been fun for a while to have the same function calling GitHub API
in every single script, but we're going to have fun in different ways
now.

This one's for you, @MrSubidubi! 🥂 

## Testing

I've ran the things that had `--dry-run` locally and nothing blew up,
but the ultimate smoke test will be carried out in production.

---

Release Notes:

- N/A
2026-09-04 11:40:05 +00:00
Lena 63e31fb7af Add issue upvotes to the community PR board (#63692)
We already had the PR's upvotes (all the positive reactions,
deduplicated by user); this commit adds the issue-closed-by-the-PR's
upvotes (deduplicated against the PR's upvoters too). The code got even
uglier because I'm trying to avoid extra API calls.

Release Notes:

- N/A
2026-09-03 13:28:03 +00:00
Kirill Bulatov 8a4bd132a6 Strip local symbols from macOS and Linux release bundles (#63429)
Not sure if this PR is 100% good, since it removes symbols from local
traces, leaving addresses only — but this what Windows seem to do
already, and we have those symbols on Sentry to restore from, which were
needed to normally read Linux perf traces already (see `perf.zip` in
https://github.com/zed-industries/zed/issues/59689#issuecomment-5452720248)

On the upside, uncompressed binaries' are now ~100MB less, which is a
lot — hence decided to open the PR for the review

-------------------

Strips debug info and local symbols from shipped macOS and Linux
binaries, matching what Windows already does with PDBs: `bundle-mac` now
always runs `dsymutil` before a new `strip -x` step, and `bundle-linux`
adds `--discard-all` plus `zed.dbg`/`remote_server.dbg` extraction via
`--only-keep-debug`.

Sentry uploads are unchanged and precede stripping.

The macOS binary UUID and the GNU build id survive stripping, so
user-provided traces stay recoverable without rebuilding at the
reporter's commit: `sample` output resolves via `atos` against the
archived `zed.dwarf`, and `perf.data` via `perf buildid-cache` against
the Sentry-archived binary.

zed binary:
macOS (2026-08-29 nightly): 420478976 -> 316503984 bytes (-24.7%,
-104.0MB)
Linux (v1.17.2 aarch64): 439417448 -> 336967256 bytes (-23.3%, -102.5MB)
Downloads shrink far less, symbols compress ~7:1: the macOS DMG loses
only ~15MB.

Release Notes:

- Improved installed size on macOS and Linux by stripping debug symbols
from release binaries (roughly -25%)
2026-09-02 19:38:12 +00:00
Conrad Irwin ff020dd053 git_ui: Batch merge conflict anchor resolution (#63394)
Improves merge-conflict loading by resolving ordered conflict anchors
with a single excerpt sweep instead of restarting the excerpt scan four
times per conflict.

The pull request also adds `script/generate-merge-conflict-benchmark`,
which creates validated small, medium, or severe repositories with real
unresolved Git merges.

On the severe workload (128 files × 256 conflicts), anchor conversion
decreased from 483.5 ms to 5.9 ms, saving about 478 ms, or roughly 5% of
the total refresh.

Closes
https://linear.app/zed-industries/issue/FR-174/improve-git-panel-performance-for-large-merge-conflicts

## Testing

- `cargo test -p multi_buffer
test_ordered_buffer_anchor_ranges_to_anchor_ranges`
- `cargo test -p git_ui conflict`
- `./script/clippy -p multi_buffer -p git_ui`
- Generated and validated the small synthetic merge-conflict workload

Release Notes:

- Improved performance when opening large merge conflicts
2026-08-31 15:07:24 +00:00
Kirill Bulatov 6840b8d2fc Fix repo docs (#63486)
* ensures The Rule cannot be accidentall removed
* fixes the perf command example to capture call graphs, to avoid
round-trips like
https://github.com/zed-industries/zed/issues/59689#issuecomment-5453623044
(samples without call graphs are not quite usable for investigating bugs
like these)


Release Notes:

- N/A
2026-08-31 11:00:40 +00:00
Kirill Bulatov 68b6504506 Enable share-generics in release bundle builds (#63432)
Cargo joins `build.rustflags` across config sources, so the base
`symbol-mangling-version=v0` and `tokio_unstable` flags still apply
after the newly added config.

With sccache disabled, `cargo build --release -p zed` on macOS: 
Before: zed binary 420677880 bytes
After: zed binary 375109048 bytes (-10.8%, -45.6MB)

After `strip -x` of both
(https://github.com/zed-industries/zed/pull/63429):
313879024 -> 307727432 bytes (-2.0%, -6.2MB)
The rest of the delta is the smaller symbol table. `drop_glue`
instantiations: 101778 -> 65041.

Release Notes:

- N/A
2026-08-31 05:42:11 +00:00
Kirill Bulatov 9b5b58607b Update .rules to prompt for self-review before submitting PR (#62945)
Release Notes:

- N/A
2026-08-21 10:32:14 +00:00
Lena ef50ad95b5 Automate cleanup of unsigned and stale draft pull requests (#62936)
- Notify the author when their PR has been in draft state with no new
commits for three weeks
- Close the draft PRs that didn't get updated after one more week
- Re-try the cla-bot check on PRs that are still unsigned after a week
- Close the PRs that are still unsigned after the re-try

## Testing

It works on my machine™

```
python script/github-pr-cleanup.py --dry-run
Checking 713 open pull requests
Dry-run mode: no comments or closures will be made
PR #60885: asking the CLA bot to check again
  Would comment on PR #60885:
@cla-bot check

PR #61625: asking the CLA bot to check again
  Would comment on PR #61625:
@cla-bot check

PR #57239: warning about a stale draft
  Would comment on PR #57239:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

PR #57241: warning about a stale draft
  Would comment on PR #57241:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

PR #61461: warning about a stale draft
  Would comment on PR #61461:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

PR #61722: warning about a stale draft
  Would comment on PR #61722:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

PR #61808: warning about a stale draft
  Would comment on PR #61808:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

PR #61809: warning about a stale draft
  Would comment on PR #61809:
<!-- zed-community-automation:stale-draft-warning -->

This pull request has remained in draft without new commits for three weeks.
If it remains a draft without new commits for another week, it will be closed
automatically.

Cleanup complete: 0 unsigned PR closures, 6 draft warnings, 0 draft closures
```



Release Notes:

- N/A
2026-08-21 07:53:28 +00:00
Lena 84aaa52595 Remove unused triage project sync workflow (#62992)
We're not using it at the moment, so, removing it to avoid confusion
with the other triage-related automations.

Release Notes:

- N/A
2026-08-21 07:06:56 +00:00
Neel 1b04e4caf0 Stop bundling GLib in Linux release archives (#61593)
Bundled GLib shadowed the system libraries for host plugins dlopen'd
into the process, like PipeWire's videoconvert on 1.6+, which would
break Wayland screen sharing on newer distros. This PR makes Zed rely on
system GLib instead, since the bundled version pulls from whatever is in
CI (presently Ubuntu 20.04).

Release Notes:

- Removed GLib libraries from Linux release bundle, which could conflict
with system plugins
2026-08-20 10:20:14 +00:00
Neel 282f47a544 Switch from cargo-machete to cargo-shear (#62643)
This results in ~110 crates being removed, and some orphaned files also.

---

Release Notes:

- N/A

Signed-off-by: Neel <neel@zed.dev>
2026-08-20 10:08:48 +00:00
ADITYA CHAUHAN bf65fd4d7c legal: Use absolute URLs for Terms of Service and Privacy Policy links (#62684)
Release Notes:

- Fixed broken links in the installer Terms of Service dialog (#62677).

---

### Description

Closes #62677

In `script/terms/terms.rtf` and `legal/terms.md` (as well as
`legal/privacy-policy.md` and `legal/third-party-terms.md`), relative
URLs like `/privacy-policy` and `/acceptable-use-policies` caused error
-50 ("The application can't be opened") when clicked from installer
dialogs (such as the macOS installer).

This PR updates the relative URLs to absolute `https://zed.dev` URLs so
they open properly in the browser.
2026-08-17 09:35:54 +00:00
Smit Barmase c95e0c5105 Add new area labels to community PR track mapping (#62314)
Label | Description
-- | --
area:integrations/git/panel | Feedback for the Git panel UI and
behavior.
area:gpui/graphics/wgpu | Feedback for GPUI's WGPU graphics backend,
including initialization and rendering.
area:breadcrumbs | Feedback for editor path and symbol breadcrumbs.
area:title bar | Issues suitable for title bar.
area:ai/agent thread/checkpoints | Feedback for Agent checkpoint
creation, comparison, restoration, and related Git behavior.
area:ai/agent thread/tools | Feedback for built-in Agent tools,
including execution, permissions, inputs, and outputs.

Release Notes:
- N/A
2026-08-07 11:11:10 +00:00
Lena 98f39bfcca Duplicate Bot: Improve candidate retrieval (v6) (#62011)
Release Notes:

- N/A
2026-07-31 15:45:04 +00:00
Lena 59cb143caf Fix triage queue board matching every open issue (#61993)
Our date filter used two qualifiers ("created:>START created:<=END"),
which isn't valid range syntax, so GitHub ignored it and returned every
open issue. Use a single "created:START..END" range. Also fix the window
math, which was a business day too recent and excluded its start day.

Release Notes:

- N/A
2026-07-31 12:44:52 +00:00
Yassen Damyanov b209000d28 Make Install script reject 32-bit Linux architectures (#61919)
# Objective

Prevent successful installations on 32-bit Linux architectures where the
`zed` binary will **fail to execute** post-installation. Rather, fail at
installation time with a proper verdict.

`script/install.sh` maps `uname -m` onto the two architectures Zed
publishes builds for. Two of the matchers named 32-bit userlands and
mapped them onto a 64-bit tarball:

- `linux-armhf` mapped to `aarch64`
- `linux-i686*` mapped to `x86_64`

Neither can execute the binary it selected. Tested on i386 Debian Trixie
container: the installer downloaded, unpacked, symlinked and reported
success, and the failure surfaced later as an exec error -- see
[Showcase](##showcase).

Thus the installer's correct behavior would be to reject the 32-bit
architecture and terminate with an "unsupported" verdict.


## Solution

Remove the case-statement-based mapping of `linux-armhf` to `aarch64`,
and of `linux-i686*` to `x86_64`.


## Testing

Tested in isolation, simulating supported and unsupported platforms, and
supported and unsupported architectures:

| Platform | `uname -m` | Outcome |
| --- | --- | --- |
| Linux | `x86_64` | ✅ Installed — resolves to `x86_64`, symlink created
|
| Linux | `i386` | ❌ Unsupported — `i386` doesn't match glob `x86*` (no
case handles plain i386 anyway |
| Linux | `i686` | ❌ Unsupported — same reason |
| Linux | `aarch64` | ✅ Installed — resolves to `aarch64` |
| Linux | `arm64` | ✅ Installed — resolves to `aarch64` |
| Linux | `armv7l` | ❌ Unsupported — no 32-bit ARM case |
| Linux | `riscv64` | ❌ Unsupported |
| Darwin | `arm64` | ✅ Installed — resolves to `aarch64`, copied to real
`/Applications/Zed.app`, symlink created; |
| Darwin | `x86_64` | ✅ Installed — resolves to `x86_64`, copied to real
`/Applications/Zed.app`, symlink created |
| Darwin | `i386` | ❌ Unsupported — no case for macOS 32-bit |
| FreeBSD | `x86_64` | ❌ Unsupported platform - expected |

This is all correct behavior. Successful installations are expected to
work. Unsupported architectures are detected and rejected as unsupported
during installation.

## Showcase

```plaintext
~# file /usr/bin/dash  # a sample executable showing the 32-bit arch
/usr/bin/dash: ELF 32-bit LSB pie executable, Intel i386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, BuildID[sha1]=7e2e8652114c8c2ae595b6f78798716a9ba07671, for GNU/Linux 3.2.0, stripped

~# file .local/zed.app/bin/zed
.local/zed.app/bin/zed: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=e550eeb1d97f0cdac2460de672bfa36e9e3f6e25, not stripped

~# .local/zed.app/bin/zed
bash: .local/zed.app/bin/zed: cannot execute: required file not found
# It cannot find  ELF 64-bit interpreter /lib64/ld-linux-x86-64.so.2 -- this is
# a 32-bit container on a 64-bit host. On a genuine 32-bit host it would fail with:
# `Exec format error`.
```


## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Locally conducted tests cover the new/changed behavior

---

Release Notes:

- N/A
2026-07-31 09:48:15 +00:00
Lena 5786fee55a Duplicate Bot: Discussions, second critic, more context (v5) (#61948)
Release Notes:

- N/A
2026-07-30 16:56:19 +00:00