Files
Christopher Eades 6e7c5d3ae8 agent: Accept stringified line numbers in read_file tool (#67072)
## Summary

This addresses when agents send strings for `start_line` and `end_line`
which cause an error:
> string "300", expected u32
The agent can go pathological and blow the context out which causes it
to fail the assigned task worst case, but wastes a lot of tokens
otherwise.

Closes #67071

## Testing

Unit tests have been updated such that testing the string serialized
`start_line` and `end_line`, as well as integers, are now both parsed by
serde. Agent testing with local models, qwen3.8:27b via ollama, no
longer run into the serialization problem.

I've been running a dev compiled binary for about a week with this
change and have used the agent several times in many projects, including
to address another issue with the `terminal` tool leaking instructions
to the agent when the `terminal` has been denied (which I'll open
separately) and the agent is performing well with the dev binary
containing the change to the `read_file` tool.

See the attached screenshots for the previous behavior:

<img width="1257" height="1748" alt="image"
src="https://github.com/user-attachments/assets/0ab948a9-8d8e-40ba-9997-21f6dcccbca3"
/>

The new behavior:

<img width="1610" height="1802" alt="image"
src="https://github.com/user-attachments/assets/4a410892-402b-4702-84d3-3268d7e78a33"
/>

## Self-review

- [X] I've reviewed my diff for quality, security, reliability, and
performance.
- [X] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [X] Tests cover the new or changed behavior.

Release Notes:

- Fixed the agent's `read_file` tool failing when models pass
`start_line`/`end_line` as strings.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
2026-11-17 07:17:22 +00:00
..