mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
698368515d
## Summary Following #65572, Zed loads BYOK Gemini models dynamically from Google's `v1beta/models` catalog, while keeping model-specific thinking level rules in `google_ai` because the catalog endpoint only reports a boolean `thinking` flag. Google's newly released [Gemini 4 Hydrogen (`gemini-4-hydrogen`)](https://aistudio.google.com/docs/models/gemini-4-hydrogen) introduces a fourth thinking level (`xhigh` / `"XHIGH"`) and defaults to `high` rather than `medium` (while rejecting `minimal`). Without explicit support in `google_ai`, `Extra High` is omitted from Zed's thinking effort selector and Hydrogen defaults to `Medium`. This PR: - Adds `ThinkingLevel::XHigh` (`"Extra High"` / `"xhigh"`, serialized as `"XHIGH"` on `generateContent` requests). - Adds `supports_xhigh_thinking` so `Model::from_listed` exposes `[Low, Medium, High, XHigh]` on `gemini-4-hydrogen` while keeping other level-based models capped at `High` (ensuring BYOK `stream_completion` strips `"xhigh"` when switching threads to models that reject it). - Updates `default_thinking_level` to map `"gemini-4-hydrogen"` to `ThinkingLevel::High`. - Filters `request.thinking_effort` against `config.supported_effort_levels` on hosted Google requests in `language_models_cloud` before calling `into_google`, matching the BYOK provider so switching a thread from `xhigh` to a hosted Gemini model that doesn't accept it falls back to the model default instead of failing validation. ## Testing - `cargo test -p google_ai` (33 passed) - `cargo test -p language_models provider::google::tests` (1 passed) - `./script/clippy -p google_ai` - `cargo fmt -p google_ai -p language_models -p language_models_cloud -- --check` Reviewers with a Gemini API key (or Zed Cloud access) can select `Gemini 4 Hydrogen` in the Agent Panel and verify that thinking effort defaults to `High`, lists `Low`, `Medium`, `High`, and `Extra High`, and falls back gracefully when switching to `Gemini 4 Argon` or `Gemini 4 Carbon`. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Added Extra High thinking effort support and High default thinking level for Gemini 4 Hydrogen (`gemini-4-hydrogen`). --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>