mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
849b5b8e07
## Summary Closes #66920 Make the header section sticky so that finish button is always in viewport. Before, the tree was: ``` div (root, scrollbar here) └─ div#page-content (scrolls) └─ v_flex (780px, p_12, gap_6) ├─ header row ├─ divider └─ page body ``` After, it is: ``` v_flex (root) ├─ v_flex ← header block, flex_none (never scrolls) │ ├─ header row │ └─ divider └─ div (relative, flex_1, min_h_0, scrollbar here) └─ div#page-content (scrolls, track_scroll) └─ v_flex (780px, px_12, pb_12) └─ page body ``` ## Testing I have tested the page in various themes, the header cleanly merges with the rest of page body without the overhanging padding in sticky section. Before: Header (and finish onboarding button) would scroll out of view. <img width="1496" height="388" alt="Screenshot 2026-11-13 at 12 06 35 PM" src="https://github.com/user-attachments/assets/2399c54f-58d5-4c87-8517-7deaf7409cbf" /> After: Header sticks to top while the rest of page content scrolls. <img width="1257" height="783" alt="Screenshot 2026-11-17 at 11 39 15 AM" src="https://github.com/user-attachments/assets/2569d16a-dd72-48d9-b46a-b900f1885bb1" /> https://github.com/user-attachments/assets/07ab374c-cede-4458-95a2-48012bbe738d ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Improved the onboarding page to keep the "Finish Setup" button visible while scrolling. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>