## Summary Closes #66654 When the tab switcher is opened from the terminal panel and a terminal is closed from the list, its row stayed in the list until the switcher was reopened. The cause: the tab switcher only refreshed on the workspace's `ItemAdded` / `ItemRemoved` events, and the workspace only emits those for panes in the center area. The terminal panel has its own pane, so its item changes never reached the switcher. The fix: `TabSwitcher::open` already finds the focused dock panel's pane. I now pass that pane to the delegate and subscribe to its `AddItem` / `RemovedItem` events directly. Center panes still use the existing workspace subscription, so nothing refreshes twice. I moved the shared refresh code into a small `refresh_matches` helper so both subscriptions use it. Before: see the recording attached to #66654. After: https://github.com/user-attachments/assets/2e664c88-a7f4-43c1-b770-787354a4a471 ## Testing - Added `test_close_item_in_dock_pane`: opens the switcher on a pane outside the workspace center, closes an item, and checks the list updates. - `cargo test -p tab_switcher` passes, and clippy is clean. - Manually tested on Windows 11: opened 3 terminals in the terminal panel, focused the panel, pressed ctrl-tab, and closed one with ×. The row now disappears immediately while the switcher stays open. To test: open 2+ terminals in the terminal panel, focus it, hold ctrl and press tab, then click × on a row. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed closed terminals staying in the tab switcher until it was reopened.
Terminal View
Design Notes
This crate is split into two conceptual halves:
- The terminal.rs file and the src/mappings/ folder, these contain the code for interacting with terminal emulator backends and maintaining the pty event loop. Some behavior in this file is constrained by terminal protocols and standards. The Zed init function is also placed here.
- Everything else. These other files integrate the
Terminalstruct created in terminal.rs into the rest of GPUI. The main entry point for GPUI is the terminal_view.rs file and the modal.rs file.
ttys are created externally, and so can fail in unexpected ways. However, GPUI currently does not have an API for models than can fail to instantiate. TerminalBuilder solves this by using Rust's type system to split tty instantiation into a 2 step process: first attempt to create the file handles with TerminalBuilder::new(), check the result, then call TerminalBuilder::subscribe(cx) from within a model context.
The TerminalView struct abstracts over failed and successful terminals, passing focus through to the associated view and allowing clients to build a terminal without worrying about errors.
Backend Boundary
terminal.rs exposes backend-neutral domain types such as terminal content, cells, modes, points, ranges, scroll commands, vi motions, hyperlinks, and search matches. UI code should depend on those types instead of importing backend-specific terminal types directly.
The current implementation is still Alacritty-backed, but the abstraction boundary keeps backend details concentrated in the terminal crate:
terminal_viewrendersTerminalContentand dispatches backend-neutral actions.- Panels and tools use terminal-domain types for mode, cursor, range, hyperlink, and search behavior.
- Backend-specific conversions stay near the terminal event loop and render snapshot code.
This keeps the user-facing terminal behavior unchanged while making future backend experiments reviewable as backend implementations instead of UI-wide refactors.
Input
There are currently many distinct paths for getting keystrokes to the terminal:
-
Terminal specific characters and bindings. Things like ctrl-a mapping to ASCII control character 1, ANSI escape codes associated with the function keys, etc. These are caught with a raw key-down handler in the element and are processed immediately. This is done with the
try_keystroke()method on Terminal -
GPU Action handlers. GPUI clobbers a few vital keys by adding bindings to them in the global context. These keys are synthesized and then dispatched through the same
try_keystroke()API as the above mappings -
IME text. When the special character mappings fail, we pass the keystroke back to GPUI to hand it to the IME system. This comes back to us in the
View::replace_text_in_range()method, and we then send that to the terminal directly, bypassingtry_keystroke(). -
Pasted text has a separate pathway.
Generally, there's a distinction between 'keystrokes that need to be mapped' and 'strings which need to be written'. I've attempted to unify these under the '.try_keystroke()' API and the .input() API (which try_keystroke uses) so we have consistent input handling across the terminal