mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
430a781076
## Summary Repeated language server messages could stack identical notifications while previewing themes. - Skip an actionless prompt when a visible prompt has the same server name, level, and message. - Compare those fields directly while retaining per-request numeric IDs and keeping action-bearing prompts independent. - Preserve the existing notification and its dismissal timer when discarding a duplicate. - Move LSP-specific auto-dismiss setup into the prompt instead of generic notification handling. Implementation: [`show_language_server_prompt`](https://github.com/zed-industries/zed/blob/ffaa5fbe8c30bc819c3d118e688b28c1f1a64fe1/crates/workspace/src/notifications.rs#L228-L253) and [`LanguageServerPrompt::new`](https://github.com/zed-industries/zed/blob/ffaa5fbe8c30bc819c3d118e688b28c1f1a64fe1/crates/workspace/src/notifications.rs#L274-L303). This changes visible-notification handling, not the upstream settings-to-LSP configuration refresh path.  ## Testing ### Automated validation - `cargo test --offline -p workspace --lib`: 309 tests passed on the updated PR branch. - The notification tests also passed across 20 scheduler seeds before the cleanup was moved onto the PR branch. - The new deduplication tests failed on `main` with only the tests and their dev-dependency added, confirming coverage of the original stacking bug. - Coverage includes server and severity differences, delimiter collisions, empty/Unicode/64-KiB messages, mixed action/no-action prompts, dismissal, suppression, disabled auto-dismiss, and a duplicate arriving 999 microseconds into a 1 ms timeout. - Scoped Rust formatting and `git diff --check` passed. The follow-up cleanup was validated with automated tests, not a visual app run. ### Original contributor's manual testing The original contributor reported manual testing on Linux (X11, XFCE), using ZLS 0.17.0 with Zig 0.18.0-dev to produce a version-mismatch warning. They also supplied this alternative rust-analyzer configuration for triggering a warning: ```json { "lsp": { "rust-analyzer": { "initialization_options": { "checkOnSave": "invalid" } } } } ``` 1. Open a file handled by the affected language server and wait for its warning notification. 2. Run `theme selector: toggle` and move through several themes. 3. Check that identical actionless notifications do not stack. ## Original contributor's self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed duplicate language server notifications appearing when switching themes. --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>