mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-20 15:40:29 +01:00
2568d560f1
## Summary > In the doc comments inside Zed's settings code, there were 11 settings where the default value written after "Default:" differs from the actual default value (`default.json`). > > For `terminal.bell`, the description of the PR that added it (#53752) says it is "enabled by default", but the merged value is `"off"`, and the release note also says "can be enabled by setting `terminal.bell` to `"system"`", so I judged that `"off"` is correct. > > This is related to #53323, but I did not fix the settings mentioned in that issue (such as `proxy`), so I did not use "Closes". (Machine-translated from Japanese. Original:) Zed の設定のコード内にある説明コメントで、「Default:」に書かれた既定値が、実際の既定値(`default.json`)と違うものが11個ありました。 `terminal.bell` は、追加したPR(#53752)の本文に「既定で有効」とありますが、マージされた値は `"off"`、リリースノートも「`"system"` にすると有効になる」となっていたので、`"off"` が正しいと判断。 #53323 に関連しますが、この issue で挙げられている設定(`proxy` など)は直していないので、Closes にはしていない。 | Setting | Doc comment said | `default.json` | | --- | --- | --- | | `expand_excerpt_lines` | `3` | `5` | | `diagnostics_max_severity` | `warning` | `all` | | `terminal.line_height` | `comfortable` | `standard` | | `terminal.bell` | `"system"` | `"off"` | | `pane_split_direction_horizontal` | `"up"` | `"down"` | | `pane_split_direction_vertical` | `"left"` | `"right"` | | `tabs.show_close_button` | `false` | `hover` | | `git.branch_picker.show_author_name` | `false` | `true` | | `file_finder.prefill_query_from_selection` | `true` | `false` | | `base_keymap` | `VSCode` | `Zed` | | `agent.thinking_display` | `automatic` | `auto` | ## Testing > In the installed Zed, when I wrote `"expand_excerpt_lines": 5` in settings.json and hovered over it, it showed "Default: 3" even though the actual default is 5. For settings with a fixed set of values (such as `bell`), hovering only shows the description of the value, so the `Default:` line is only visible for number and true/false settings. (Machine-translated from Japanese. Original:) インストール版の Zed で settings.json に `"expand_excerpt_lines": 5` を書いてホバーすると、実際の既定値は 5 なのに「Default: 3」と表示された。選択肢の設定(`bell` など)はホバーで値の説明しか出ないので、`Default:` の行が見えるのは数値や true/false の設定だけだった。 <img width="890" height="223" alt="zed-hover-default" src="https://github.com/user-attachments/assets/d43170df-610c-4d74-bd5c-3e1e5391ad9f" /> Doc comments only; no code changes. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [ ] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [ ] Tests cover the new or changed behavior. Release Notes: - N/A