mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 15:10:34 +01:00
58be7923cf
## Summary Split out of #66953. Zed runs `git blame --contents -` and writes the buffer text into git's stdin. when the file is not in HEAD (new or untracked), git exits without reading stdin. if the buffer is over 64KB (checked on my macOS) the write fails with `Broken pipe` and Zed returns that error instead of empty blame. I guess on Linux it will also fail because 64 KB is default pipe size. steps to reproduce: 1. In git repository create an untracked file larger than 64 KB and open it in Zed. 2. cmd+shift+p(macOS) and select "Run editor: toggle git blame" 3. On main you should get an error toast containing `Broken pipe` <img width="1509" height="793" alt="Screenshot 2026-11-17 at 23 20 02" src="https://github.com/user-attachments/assets/663550fc-44d7-4a57-add4-c45415a73bb9" /> the fix: check git exit status first and report the write error only after that. after fix no error: <img width="1509" height="807" alt="Screenshot 2026-11-17 at 23 29 18" src="https://github.com/user-attachments/assets/f570f228-17c9-4149-93c9-5569cbfc751a" /> ## Testing manually tested, no broken pipe error. Added `test_blame_untracked_path_with_large_contents`. On `main` it fails with `Broken pipe (os error 32)`; with this change it passes. Ran the `git` crate tests on macOS. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] N/A UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed git blame failing with a broken pipe error for large untracked files. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>