mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 23:20:18 +01:00
395fbd11b8
# Objective A manual "check for updates" that finds no newer version left the updater back at `Idle`, so the "Checking for Zed Updates…" indicator in the title bar simply vanished with no confirmation that the check had succeeded. ## Solution Track that transition in `UpdateVersion` and show an "Up to Date" button in its place for a few seconds. The timer is stored as a task on the view, so it is cancelled when the view is dropped or a new update state arrives. `restart_after_wake` passed through `Idle` before re-polling, which would read as a completed check; it now stays in `Checking`. ## Testing - Did you test these changes? If so, how? **Tested by running Zed in preview channel.** - Are there any parts that need more testing? **No** - How can other people (reviewers) test your changes? Is there anything specific they need to know? **Use `ZED_RELEASE_CHANNEL=preview cargo run` to open Zed. Then manually trigger a check within menu `Zed -> Check for Updates`.** - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? **Tested only on MacOS Tahoe** ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Showcase A visual demo of what happens in title_bar when a manual check for updates is triggered. https://github.com/user-attachments/assets/23b72bf2-6188-4eae-82b9-1c5b70782bb4 --- Release Notes: - Added confirmation in the title bar when a manual update check finds Zed is already up to date