mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
130f1e92a4
## Summary Update Zed's TLS certificate dependencies, managed Node runtime, and Wasmtime stack to address the eMudhra intermediate compromise and recent Wasmtime sandbox vulnerabilities. - Update `rustls-webpki` to 0.103.16, `webpki-roots` to 1.0.10 and its legacy wrapper to 0.26.11, and `webpki-root-certs` to 1.0.10. SQLx's legacy wrapper resolves to the patched 1.0.10 root data. - Update managed Node from 24.21.0 to 24.22.1. - Update Wasmtime, WASI, and Tree-sitter's Wasmtime C API from 48.0.1 to 48.0.7, with aligned Cranelift 0.135.7 and required Wasm tooling patches. Keep the existing Wasmtime feature set. ## Testing Local platform: macOS arm64, Rust 1.98.1. - `cargo build --locked -p zed --bin zed`: passed. Launched the new binary with isolated user data and a temporary Rust file; the process remained running. A user-provided screenshot confirms `app-smoke.rs` opened and rendered with Rust syntax highlighting. Interactive GUI checks were not completed: the UI automation tool failed to initialize and macOS denied the Apple Events fallback. This PR remains a draft for human review and any further manual validation. - `ZED_HEADLESS=1 cargo test --locked -p extension_host -p node_runtime -p reqwest_client --lib`: passed. The extension-host integration test builds, installs, and runs the real test extension, including relative/absolute filesystem operations and process execution. ```text extension_host: 46 passed; 0 failed node_runtime: 24 passed; 0 failed reqwest_client: 4 passed; 0 failed ``` - `cargo check --locked -p extension_host -p extension_cli -p language`, `./script/clippy --locked -p node_runtime -p reqwest_client`, formatting, and diff whitespace checks passed. The lint wrapper's optional cargo-shear/typos/buf checks were not run because cargo-shear was unavailable. - Isolated native aarch64 checks passed: oversized branch tables rejected at 65,521 and 262,146 targets; a table at the supported 65,520 limit executes correctly; component instantiation and the pinned Tree-sitter C API WasmStore work. WASI read/write/rename and internal symlinks work with Zed's dual ReadWrite preopens; the trailing-slash outside symlink rename and parent traversal are rejected without modifying the outside sentinel. - Isolated TLS checks passed: WebPKI 0.103.16 rejects all 12 captured incident certificate chains with `CertDistrusted`, including when supplied the old roots. The patched root bundles omit the affected root. The official native Node archive matches its published SHA-256; Node rejects all 12 incident hosts with `CERT_REVOKED` and accepts an ordinary verified TLS control request. - The standalone probes are local validation artifacts, not added repository tests. Reviewers can rerun the Cargo commands above; for manual validation, launch the build, open a source file, and install/run a Wasm extension and a Wasm grammar. Linux/Windows runtime testing and a full workspace test run were not performed. The debug app build emits a large unwind-table linker warning and a future-compatibility warning for `block`. ## Self-review The dependency diff was reviewed for scope, version alignment, feature changes, and sandbox compatibility. Two incidental dependency-link changes selected by Cargo were removed; only the intended security updates remain. README's review notice is retained because repository rules reserve its removal for the human author. - [x] I've reviewed my diff for quality, security, reliability, and performance. (Human author review pending.) - [ ] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). (N/A; no UI changes.) N/A - [x] Tests cover the new or changed behavior. ## Suggested .rules additions When checking a Cargo.lock update for scope, compare dependency lists for packages whose own versions did not change; Cargo can reselect their already-locked transitive versions. Release Notes: - Updated dependencies to address recent software ecosystem vulnerabilities.