Files
zed/crates
Dino 38f5c4af0d git_ui: Fold buffers in commit view as soon as possible (#67111)
## Summary

When `git.commit_view.expand_files` is set to `false`, opening a git
commit will fold all buffers, except the file from which this was
opened, if any.

However, this was done by collecting all of the `BufferId` and then
calling `Editor::fold_buffers` once, after all excerpts had been
processed, which could lead to scenarios where the file's excerpts would
first "flicker" on screen before the buffers being folded.

This commit updates the approach such that, instead of collecting
`BufferId`, we now call `Editor::fold_buffer` in
`CommitView::append_commit_file` as soon as the first batch of excerpts
for the buffer is processed, meaning we fold the buffer as soon as
possible to avoid showing any excerpts at all.

Mostly picking up work from #66754 that wasn't shipped.

## Testing

Testing was done manually, as doing it programmatically would require us
introducing test helpers to pause the excerpts loading, which didn't
seem necessary for this change. A new test was added –
`test_reveal_binary_file_preserves_folded_header_position` – but it's
simply to ensure that we fold binary files, even if they're the target
file.

### Showcase

<details>
  <summary>Before</summary>


https://github.com/user-attachments/assets/5c454af9-9326-4053-b6e5-dd1f288d2a81
</details>

<details>
  <summary>After</summary>
  

https://github.com/user-attachments/assets/94a56424-2158-44ec-86d3-3c07c7ebd7a6
</details>

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- Fixed files in the commit view briefly appearing expanded before
collapsing when `git.commit_view.expand_files` is disabled.
2026-11-18 10:46:43 +00:00
..
2026-11-11 19:41:39 +00:00
…
…
…
…
…
…
2026-11-17 12:43:21 +00:00