mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 15:10:34 +01:00
14b7b0ef37
Replaces the `kde-blur` protocol (which is now deprecated and being [removed from kde](https://invent.kde.org/plasma/kwin/-/commit/7f9e0aa1cd2c2ab4fea1097800893b6f780089eb)) with the new [ext-background-effect](https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/staging/ext-background-effect/ext-background-effect-v1.xml) protocol (which is supported by niri, new KDE releases, and more compositors over time) # Current questions - Currently, the PR completely removes the old KDE blur and replaces it. Should we keep the old kde-blur implementation and use it as a fallback? - Since the protocol technically supports adding new capabilities and types of background effects, should zed track if the compositor supports the protocol, and only try blurring then? The protocol seems to imply that you can still use [set_blur_region](https://wayland.app/protocols/ext-background-effect-v1#ext_background_effect_surface_v1:request:set_blur_region), but the compositor will do nothing - Since the protocol is generic, should it be checked when resizing to see if the window should be blurred before updating the blur region? Currently it doesn't do it, since it's implied (a note has been added to the code) - I wonder if this could be expanded to where popovers (such as diagnostic popovers) can become their own wayland surfaces, and thus also be blurred (so a transparent warning popover/diagnostic can properly blur the text underneath for readability, rather than it having to be opaque). That sounds like a major refactor/out of scope though, not even sure if it's possible (I'd love to work on it though, if the team has any pointers on how to get started) I'm keeping this PR as a draft until those points are figured out/commented on Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [/] Tests cover the new/changed behavior - I do not know how to test this, and the old implementation wasn't tested - [/] Performance impact has been considered and is acceptable - I don't see how this would affect performance Release Notes: - [GPUI] wayland: deprecate kde-blur protocol, implement and default to ext-background-effect --------- Co-authored-by: Alexander Bachmann <a.t.bachmann@gmail.com> Co-authored-by: Tom Houlé <tom@tomhoule.com>