mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-20 15:40:29 +01:00
b41a8b60a4
## Summary
Zed was detecting `CMD.EXE` as PowerShell because the filename check was
case-sensitive. This fixes shell detection on Windows while keeping Unix
behavior unchanged.
## Testing
- Built and ran Zed on Windows. A task using `"shell": {"program":
"CMD.EXE"}` and `"command": "echo zed-shell-case-probe"` printed
`zed-shell-case-probe`.
- Added regression tests covering 22 Windows and Unix cases.
- `cargo fmt --all -- --check` and `./script/clippy.ps1 -p util
--locked` passed.
- `cargo test -p util --locked`: 128 unit tests and 2 doctests passed; 1
doctest ignored.
- Workspace doctests: 150 passed, 22 ignored.
- Full Windows workspace suite: 10,809 tests run, 26 skipped. Initially
10,798 passed, 3 failed, and 8 timed out. Nine setup-related cases
passed on retry after preparing the extension fixture, fetching the
remaining locked dependencies, and setting `CRITERION_HOME` to avoid
Criterion's runtime Cargo metadata lookup.
Two failures remain in unchanged tests, so the full suite is not
entirely green locally:
-
`extensions_ui::extension_suggestions::tests::test_suggestion_returns_after_failed_install`:
one pending installation where zero is expected; also fails in
isolation. This path downloads an extension through the fake HTTP
client, outside shell detection.
- `gpui_windows::window::tests::test_double_click_interval`: the test
assumes a 700 ms gap resets the click count, while this machine's
double-click interval is 760 ms.
## Self-review
- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI checklist: not applicable (no UI changes).
- [x] Tests cover the new or changed behavior.
Release Notes:
- Fixed Windows shell detection for executable names containing
uppercase letters.