mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-20 07:30:22 +01:00
925ee76e1b
## Summary Removes unused code, redundant checks, and lint suppressions that no longer do anything. No behavior changes. - `settings`: removes the `EditableSettingControl` trait, which had no implementations. - Removes unused helpers in `util`, `paths`, `path`, `sqlez`, `clock`, `zlog`, `http_client` and `migrator`. - `settings_json` reuses a string it just built. `zlog` drops a flag that an earlier `continue` keeps `true`. `http_proxy` drops emptiness checks before `write_all`. - GPUI internals: removes a `.peekable()` that never peeks and a duplicate inspector handle clone. The Wayland client drops an `is_some()` check before setting `enter_token = None`. - Removes empty, unused Cargo features: - `test-support` in `feedback`, `http_client_tls` and `install_cli` - `perf-enabled` in `util_macros`, whose code checks the `perf_enabled` cfg instead - Also removes two `cfg_attr`s on a `nightly_coverage` feature that doesn't exist. - Removes `#[allow]` attributes for lints the workspace already allows, and ones that no longer suppress anything. ### Suggested AGENTS.md additions > Don't apply `clippy::let_unit_value` to `let _guard = span.enter()`. `ztracing` spans are `()` when tracing is off, so the lint fires, but dropping the binding ends the span early when tracing is on. ## Testing - `./script/clippy` - `cargo test -p settings -p util -p paths -p sqlez -p scheduler -p zlog -p crashes -p http_proxy -p gpui` ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - [GPUI] Removed unused internal code and stale lint suppressions