mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
Update piper to fix truncated file writes (#67160)
The zip extraction tests in `crates/util/src/archive.rs` fail intermittently on Linux CI with errors such as `unable to locate the end of central directory record`, for example in [this run on main](https://github.com/zed-industries/zed/actions/runs/44141138965). The cause is a bug in `piper` 0.2.4, where closing the `Writer` right after writing can make the `Reader` lose bytes (fixed upstream in smol-rs/piper#31, released as 0.2.5). This only bumps `piper` in `Cargo.lock`. ## Testing I reproduced the failure by running a test that extracts a small zip 20,000 times in a loop, with 48 copies of it running concurrently to create CPU contention: - `piper` 0.2.4: 47 of 48 runs failed, with `unable to locate the end of central directory record`, `unexpected end of file`, or an empty extracted file. - `piper` 0.2.5: 0 of 96 runs of the full `archive::tests` module (including the loop) failed. The loop test is not included, since it only fails under heavy load and exercises a dependency rather than our code. Release Notes: - Fixed a rare issue where files written by Zed, such as extracted downloads, could be truncated
This commit is contained in:
Generated
+2
-2
@@ -13518,9 +13518,9 @@ checksum = "8b870d8c151b6f2fb93e84a13146138f05d02ed11c7e7c54f8826aaaf7c9f184"
|
||||
|
||||
[[package]]
|
||||
name = "piper"
|
||||
version = "0.2.4"
|
||||
version = "0.2.5"
|
||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||
checksum = "96c8c490f422ef9a4efd2cb5b42b76c8613d7e7dfc1caf667b8a3350a5acc066"
|
||||
checksum = "c835479a4443ded371d6c535cbfd8d31ad92c5d23ae9770a61bc155e4992a3c1"
|
||||
dependencies = [
|
||||
"atomic-waker",
|
||||
"fastrand 2.3.0",
|
||||
|
||||
Reference in New Issue
Block a user