mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
fix(git_graph): match log_source to CommitViewOptions reveal_file (#67042)
## Summary closes #67003 Opening the git graph of a selected file will persist the scope of the selected file to the commit view and position that file in view automatically. Other files in the commit are still available to view and are in the same order as if there was no selected file. ### Before https://github.com/user-attachments/assets/237292dc-3a56-4f3e-a180-ef702c5a0a88 ### After https://github.com/user-attachments/assets/8bdc5735-2159-46c7-9347-3187f85f5f5d ## Testing - Open a file in the editor - Open the context menu on the file and select "View File History" - Open any commit that has the selected file + any number of additional files that were changed The current behavior is that the commit view will open to the first file rather than the file selected from the editor. After making the minor updates the behavior of selecting a file to open it's commit view results in that file being shown on the initial render of the view. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - N/A
This commit is contained in:
@@ -2590,11 +2590,19 @@ impl GitGraph {
|
||||
return;
|
||||
};
|
||||
|
||||
let commit_view_options = CommitViewOptions {
|
||||
reveal_file: match &self.log_source {
|
||||
LogSource::Path(path) => Some(path.clone()),
|
||||
_ => None,
|
||||
},
|
||||
..Default::default()
|
||||
};
|
||||
|
||||
CommitView::open(
|
||||
commit_entry.data.sha.to_string(),
|
||||
repository.downgrade(),
|
||||
self.workspace.clone(),
|
||||
Default::default(),
|
||||
commit_view_options,
|
||||
window,
|
||||
cx,
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user