gpui: Match keystrokes before context predicates (#66634)

## Summary

`Keymap::resolve_bindings_for_input` now matches keystrokes before
evaluating context predicates. Keystroke matching is cheaper and rejects
most bindings. Both checks are just pure filters so lookup results are
identical.

Avg time per `Keymap::bindings_for_input` call over 48 common keystrokes
in editor context. Windows 11 Ryzen 7 9800X3D.

| Keymap | Before | After |
|---|---|---|
| Linux | 15.5 µs | 1.26 µs |
| Linux + vim (normal mode) | 41.4 µs | 3.05 µs |
| Windows | 14.6 µs | 1.20 µs |
| Windows + vim (normal mode) | 41.5 µs | 2.97 µs |

## Testing

Windows 11, with and without vim mode: typing, `ctrl-s`, `ctrl-shift-p`
hints, `ctrl-k ctrl-c`, `ctrl-k z`, buffer search `enter` and `escape`,
and vim `i`, `escape`, `dd`, `gg`, `G`, `ciw`, `v d`. No issues found.

- `cargo test -p gpui --features test-support`: pass.
- `cargo test -p vim -p which_key`: pass.
- `cargo test -p zed -- keymap emacs keybinding`: pass.
- Lookup results match before and after for every bound keystroke
sequence and prefix, across 13 context stacks and the Linux, Windows,
and macOS keymaps, with and without vim.

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- N/A
- [GPUI] Improved keybinding lookup performance.
This commit is contained in:
Parker Loflin
2026-11-14 11:34:19 +00:00
committed by GitHub
parent f0fa51bb51
commit d0400aaf03
+2 -2
View File
@@ -199,10 +199,10 @@ impl Keymap {
let mut pending_bindings = SmallVec::<[(BindingIndex, &KeyBinding); 1]>::new();
for (ix, binding) in keymap_bindings {
let Some(depth) = self.binding_enabled(binding, context_stack) else {
let Some(pending) = binding.match_keystrokes(input) else {
continue;
};
let Some(pending) = binding.match_keystrokes(input) else {
let Some(depth) = self.binding_enabled(binding, context_stack) else {
continue;
};