Parker Loflin 053d91cb14 agent_ui: Check for an empty message without copying the text (#67020)
## Summary

`MessageEditor::is_empty` copied the whole draft with `text(cx)` to
check whether it was blank. It now reads characters from the buffer
until one isn't whitespace. `str::trim` removes exactly the characters
that `char::is_whitespace` matches, so the result is the same.

The thread view calls it on every render, through `render_send_button`.
The thread view's observer on the message editor also copied the text
each time the editor notified, to check for an empty draft. It now uses
`Editor::is_empty`, which reads the buffer length.

Both `is_empty` checks timed on a `rope::Rope` in a release build,
median per call:

| Draft size | Before | After | Speedup |
|---|---|---|---|
| 1 KB | 112 ns | 22 ns | 5x |
| 16 KB | 1.1 µs | 24 ns | 46x |
| 256 KB | 16.6 µs | 28 ns | 590x |
| 4 MB | 271 µs | 33 ns | 8,200x |

## Testing

- `cargo test -p agent_ui --lib message_editor` passes.
- `cargo test -p agent_ui --lib conversation_view` passes.
- `./script/clippy -p agent_ui` passes.

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- N/A
2026-11-16 01:11:44 +00:00
…
…
…
…
…
…
…

Zed

Zed CI

Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.


Installation

On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).

Other platforms are not yet available:

Developing Zed

Contributing

See CONTRIBUTING.md for ways you can contribute to Zed.

Also... we're hiring! Check out our jobs page for open roles.

Licensing

Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.

License information for third party dependencies must be correctly provided for CI to pass.

We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:

  • Is it showing a no license specified error for a crate you've created? If so, add publish = false under [package] in your crate's Cargo.toml.
  • Is the error failed to satisfy license requirements for a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to the accepted array in script/licenses/zed-licenses.toml.
  • Is cargo-about unable to find the license for a dependency? If so, add a clarification field at the end of script/licenses/zed-licenses.toml, as specified in the cargo-about book.

Sponsorship

Zed is developed by Zed Industries, Inc., a for-profit company.

If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.

S
Description
No description provided
Readme 1.6 GiB
Languages
Rust 95.4%
JSON-with-Comments 2.4%
Python 0.8%
Inno Setup 0.3%
Tree-sitter Query 0.3%
Other 0.4%