Shuhei Kadowaki 1563b405f9 project: Honor document selectors of didChange and didSave registrations (#65253)
## Summary

#59243 made dynamically registered capabilities honor their document
selectors, but `textDocument/didChange` and `textDocument/didSave`
registrations still overwrote the server-wide sync options and ignored
their selectors, while `didSave` was sent for every saved file of the
worktree to every server whose options asked for saves.

These registrations are now kept per registration, with their selectors:

- The sync kind of a document's changes and whether its saves are
notified, with or without text, come from the latest registration
matching the document, falling back to the static options.
- The merged capabilities keep mirroring the latest registrations, and
unregistering now restores the static options instead of clearing them.
- A `didSave` registration without options is now honored instead of
ignored.

Static save options now only cover the documents a server was opened
with, as they apply to the documents the client selects for the server,
while `didSave` registrations may select any document of the worktree.
Registrations without a selector stand for the same documents as the
static options. This removes the broadcast of every save to every
server, which rust-analyzer no longer needs to pick up manifest changes
in Zed: with dynamic registration it declares no static save options,
and registers `didSave` for `**/*.rs` and `**/Cargo.toml` to reload its
workspace when a manifest is saved. Manifest saves keep reaching it
either way: while `pattern` matching remains fail-open, its filters
match every document, and once #65252 lands they select exactly these
files.

Documents without a language no longer match every registration, and
only match filters without a `language`.

## Testing

- Added integration tests that `didChange` and `didSave` registrations
only apply to documents matching their selectors, fall back to the
static options otherwise, and restore them when unregistered.
- Added an integration test that static save options and registrations
without a selector do not cover documents not opened in the server, that
a `language` filter does not select a document without a language, and
that a registration can select such a document.
- Updated `test_managing_language_servers`, which asserted that saving a
file notifies every server of the worktree.

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- Fixed language servers receiving change and save notifications that do
not follow their dynamic registrations, including save notifications for
unrelated files of the project.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 15:37:30 +00:00
…
…
…
…
…
…
…
…
…
…
…

Zed

Zed CI

Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.


Installation

On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).

Other platforms are not yet available:

Developing Zed

Contributing

See CONTRIBUTING.md for ways you can contribute to Zed.

Also... we're hiring! Check out our jobs page for open roles.

Licensing

Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.

License information for third party dependencies must be correctly provided for CI to pass.

We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:

  • Is it showing a no license specified error for a crate you've created? If so, add publish = false under [package] in your crate's Cargo.toml.
  • Is the error failed to satisfy license requirements for a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to the accepted array in script/licenses/zed-licenses.toml.
  • Is cargo-about unable to find the license for a dependency? If so, add a clarification field at the end of script/licenses/zed-licenses.toml, as specified in the cargo-about book.

Sponsorship

Zed is developed by Zed Industries, Inc., a for-profit company.

If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.

S
Description
No description provided
Readme 1.6 GiB
Languages
Rust 95.4%
JSON-with-Comments 2.4%
Python 0.8%
Inno Setup 0.3%
Tree-sitter Query 0.3%
Other 0.4%