## Summary When `git.commit_view.expand_files` is set to `false`, opening a git commit will fold all buffers, except the file from which this was opened, if any. However, this was done by collecting all of the `BufferId` and then calling `Editor::fold_buffers` once, after all excerpts had been processed, which could lead to scenarios where the file's excerpts would first "flicker" on screen before the buffers being folded. This commit updates the approach such that, instead of collecting `BufferId`, we now call `Editor::fold_buffer` in `CommitView::append_commit_file` as soon as the first batch of excerpts for the buffer is processed, meaning we fold the buffer as soon as possible to avoid showing any excerpts at all. Mostly picking up work from #66754 that wasn't shipped. ## Testing Testing was done manually, as doing it programmatically would require us introducing test helpers to pause the excerpts loading, which didn't seem necessary for this change. A new test was added – `test_reveal_binary_file_preserves_folded_header_position` – but it's simply to ensure that we fold binary files, even if they're the target file. ### Showcase <details> <summary>Before</summary> https://github.com/user-attachments/assets/5c454af9-9326-4053-b6e5-dd1f288d2a81 </details> <details> <summary>After</summary> https://github.com/user-attachments/assets/94a56424-2158-44ec-86d3-3c07c7ebd7a6 </details> ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed files in the commit view briefly appearing expanded before collapsing when `git.commit_view.expand_files` is disabled.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.