Ted Robertson 4191aeaf50 agent_ui: Check only the clicked pattern in pipeline permission dropdown (#56492)
Closes #55523

When the agent proposes a [chained
command](https://github.com/zed-industries/zed/issues/55523) like `ls &&
git status && git log`, the permission dropdown lists an "Always for `X`
commands" checkbox per sub-command. Clicking one checkbox activates
pattern mode with *all* patterns pre-checked, so the user appeared to be
approving every command in the pipeline even though they had only
clicked one. Pressing Allow then allow-listed every sub-command.

Fix: the first click activates pattern mode with only the clicked
pattern checked. Additional patterns require explicit checks.

**Note**: I've rebased onto `main` after #65039, which moved the
dropdown's selection state into `Conversation`. The dropdown's click
handler and the `ToggleCommandPattern` action handler now both call
`Conversation::toggle_permission_pattern`, so the fix lives in one
place. The duplicated fix and the one-click-behind workaround from the
previous version of this PR are gone.

**Self-Review Checklist**

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fixed the agent's permission dropdown for chained terminal commands
checking every command when you clicked only one.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
2026-11-16 19:20:21 +00:00
…
…
2026-09-11 09:13:44 +00:00
…
…
…

Zed

Zed CI

Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.


Installation

On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).

Other platforms are not yet available:

Developing Zed

Contributing

See CONTRIBUTING.md for ways you can contribute to Zed.

Also... we're hiring! Check out our jobs page for open roles.

Licensing

Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.

License information for third party dependencies must be correctly provided for CI to pass.

We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:

  • Is it showing a no license specified error for a crate you've created? If so, add publish = false under [package] in your crate's Cargo.toml.
  • Is the error failed to satisfy license requirements for a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to the accepted array in script/licenses/zed-licenses.toml.
  • Is cargo-about unable to find the license for a dependency? If so, add a clarification field at the end of script/licenses/zed-licenses.toml, as specified in the cargo-about book.

Sponsorship

Zed is developed by Zed Industries, Inc., a for-profit company.

If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.

S
Description
No description provided
Readme 1.6 GiB
Languages
Rust 95.4%
JSON-with-Comments 2.4%
Python 0.8%
Inno Setup 0.3%
Tree-sitter Query 0.3%
Other 0.4%