Felipe Arthur 430a781076 Fix duplicate language server notifications (#67021)
## Summary

Repeated language server messages could stack identical notifications
while previewing themes.

- Skip an actionless prompt when a visible prompt has the same server
name, level, and message.
- Compare those fields directly while retaining per-request numeric IDs
and keeping action-bearing prompts independent.
- Preserve the existing notification and its dismissal timer when
discarding a duplicate.
- Move LSP-specific auto-dismiss setup into the prompt instead of
generic notification handling.

Implementation:
[`show_language_server_prompt`](https://github.com/zed-industries/zed/blob/ffaa5fbe8c30bc819c3d118e688b28c1f1a64fe1/crates/workspace/src/notifications.rs#L228-L253)
and
[`LanguageServerPrompt::new`](https://github.com/zed-industries/zed/blob/ffaa5fbe8c30bc819c3d118e688b28c1f1a64fe1/crates/workspace/src/notifications.rs#L274-L303).

This changes visible-notification handling, not the upstream
settings-to-LSP configuration refresh path.

![Original reproduction
screenshot](https://github.com/user-attachments/assets/c3cce22e-e1b8-4047-ad44-8eda72bca659)

## Testing

### Automated validation

- `cargo test --offline -p workspace --lib`: 309 tests passed on the
updated PR branch.
- The notification tests also passed across 20 scheduler seeds before
the cleanup was moved onto the PR branch.
- The new deduplication tests failed on `main` with only the tests and
their dev-dependency added, confirming coverage of the original stacking
bug.
- Coverage includes server and severity differences, delimiter
collisions, empty/Unicode/64-KiB messages, mixed action/no-action
prompts, dismissal, suppression, disabled auto-dismiss, and a duplicate
arriving 999 microseconds into a 1 ms timeout.
- Scoped Rust formatting and `git diff --check` passed.

The follow-up cleanup was validated with automated tests, not a visual
app run.

### Original contributor's manual testing

The original contributor reported manual testing on Linux (X11, XFCE),
using ZLS 0.17.0 with Zig 0.18.0-dev to produce a version-mismatch
warning.
They also supplied this alternative rust-analyzer configuration for
triggering a warning:

```json
{
  "lsp": {
    "rust-analyzer": {
      "initialization_options": {
        "checkOnSave": "invalid"
      }
    }
  }
}
```

1. Open a file handled by the affected language server and wait for its
warning notification.
2. Run `theme selector: toggle` and move through several themes.
3. Check that identical actionless notifications do not stack.

## Original contributor's self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- Fixed duplicate language server notifications appearing when switching
themes.

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
2026-11-16 10:57:46 +00:00
…
…
…
…
…
…
…

Zed

Zed CI

Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.


Installation

On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).

Other platforms are not yet available:

Developing Zed

Contributing

See CONTRIBUTING.md for ways you can contribute to Zed.

Also... we're hiring! Check out our jobs page for open roles.

Licensing

Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.

License information for third party dependencies must be correctly provided for CI to pass.

We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:

  • Is it showing a no license specified error for a crate you've created? If so, add publish = false under [package] in your crate's Cargo.toml.
  • Is the error failed to satisfy license requirements for a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to the accepted array in script/licenses/zed-licenses.toml.
  • Is cargo-about unable to find the license for a dependency? If so, add a clarification field at the end of script/licenses/zed-licenses.toml, as specified in the cargo-about book.

Sponsorship

Zed is developed by Zed Industries, Inc., a for-profit company.

If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.

S
Description
No description provided
Readme 1.6 GiB
Languages
Rust 95.4%
JSON-with-Comments 2.4%
Python 0.8%
Inno Setup 0.3%
Tree-sitter Query 0.3%
Other 0.4%