mirror of
https://github.com/zed-industries/zed.git
synced 2026-11-19 06:59:22 +01:00
58849026ec
## Summary ## What problem does this solve, how, and why does this change matter? Ensures helix mode honors the the configured `use_system_clipboard` instead of always ignoring it and acting as if the value was `UseSystemClipboard::Never`. To be honest, I'm a bit confused why #55455 decided that Helix mode should deliberately ignore the configured setting, when the desired behavior ("not clobbering the system clipboard") is already available with `Never`, maybe @SrGaabriel can shed some light on this? I find the feature to always copy/paste to/from the system clipboard super handy, especially when using in combination with a clipboard manager. closes #66782 ## Testing Enable helix mode. When `use_system_clipboard` is set to `Always` or `OnYank`, `y` and `p` yank and paste from/to the system clipboard. When `use_system_clipboard` is set to `Never`, `y` and `p` yank and paste from/to the internal register. I mostly duplicated the tests added in #55455 and run them against the two different scenarios: `Always` and `Never`. For the tests targeting the specific registers, I removed the assumption about the system clipboard because IMO this is not what these tests should test. Let me know if that's fine or if I should iterate on that. ## Self-review - [X] I've reviewed my diff for quality, security, reliability, and performance. - [X] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [X] Tests cover the new or changed behavior. Release Notes: - Fixed Helix mode ignoring the `vim.use_system_clipboard` setting. Yank, delete and paste in Helix mode use the system clipboard by default again, as they did before 1.28 . If you wish to keep the 1.28 behavior, set `"vim": { "use_system_clipboard": "never" }` to keep using the internal register.