shift-enter in search bar for JetBrains keymap (#65129)
## Summary This PR fixes https://github.com/zed-industries/zed/issues/62696. The current JetBrains keymap binds `shift-enter` to `editor::NewlineBelow`. While that is correct for most contexts, in the search bar it is not. In the search bar JetBrains products use `shift-enter` to search backwards. The current keymap already tries to rectify this by adding an explicit `search::SelectPreviousMatch` mapping. However the precedence of this mapping is shadowed by an `Editor && mode == auto_height` match. This PR fixes the issue by giving the `search::SelectPreviousMatch` a higher precedence by making it more specific to the search bar. ## Testing (instructions for macOS) 1. Run a build with the modified keymap 2. Open a file and search via Cmd+F 3. Enter some text that occurs multiple times in the file 4. Press Shift-Enter. Notice that this searches in the document and rotates through the matches in reverse order. A note for test code: At first I didn't add a test for this change but then I saw that a test for a similar change exists (`test_thread_search_shift_enter_navigates_with_jetbrains_keymap`). The test is AI generated. As far as I can tell the test makes sense, but I'm not really familiar with the UI code. If you prefer to have the test removed/changed, please tell me. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed default Shift-Enter behavior in the JetBrains keymap to select the previous search match --------- Co-authored-by: MrSubidubi <finn@zed.dev>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.