not_in scopes being ignored at end of buffer (#64840)
## Summary "Closes #64820" Bracket `not_in` rules (like "don't auto-close `'` inside a comment") were ignored when the cursor was at the very end of the file. For example, in a C file containing only `// it ''`, typing `'` at EOF would still auto-insert a closing `'`, even though C disables that pair inside comments. The cause was in `language_scope_at` in `buffer.rs`. It walks down the syntax tree using `Range::contains`, which excludes the end of the range. At EOF, the cursor offset equals the end of the root node, so every layer got skipped. The function then fell back to a scope with no `override_id`, and all `not_in` rules were lost. The fix lets the tree walk accept the end of a node's range, but only when the cursor is at the end of the buffer. Behavior everywhere else in the file is unchanged. Huge thanks to @arixsnow who reported this in #64820 with clear repro steps and tracked the root cause. This PR implements the fix they pointed to. https://github.com/user-attachments/assets/dc3680c0-46f1-4fc1-b80a-973f18398139 ## Testing Ran `cargo test -p language`, all passed. The issue #64820 includes directions to reproduce it clearly I used the same to test the fix. ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [x] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed auto-closing brackets being inserted inside comments or strings at the end of a file. --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.