Daniel Jeon 9f1c56d6f2 gpui: Preserve empty content masks when snapping to device pixels (#67130)
## Summary

Fully clipped content can leak a 1px line outside its parent when an
empty content mask lies at a fractional device-pixel coordinate. Outward
rounding can turn the empty mask into a nonempty region.

For example, a zero-height mask with a vertical range of `[181.2,
181.2]` in device-pixel coordinates is expanded to `[181, 182]` by
[cover_bounds](https://github.com/zed-industries/zed/blob/96362135eb98a011ac17b56a5c90cf77f9f597f1/crates/gpui/src/window.rs#L3673-L3683),
which rounds the top edge down and the bottom edge up. This creates a
1px-tall region where nothing should be visible.

This change preserves empty masks before rounding while retaining the
existing behavior for positive-area masks, preventing rendering
artifacts during fractional scrolling.

Possibly related to
[#63358](https://github.com/zed-industries/zed/issues/63358), which
reports intermittent horizontal rendering artifacts on Linux/Wayland.
The symptoms are similar, but this fix has not been tested against that
report, so a shared root cause is unconfirmed.

In the native Windows screenshots below, the **blue rectangles represent
the visible body area (viewport) of a scrollable container**, and the
**red rectangles represent its content**. The example positions the
content entirely below the viewport, reproducing the state of an item
that has been scrolled out of view.

- **A — Unclipped reference:** clipping is disabled so the full red
rectangle remains visible, showing what is being drawn.
- **B — Fractional-coordinate clipping:** the same content should be
completely hidden. Before the fix, its top pixel row leaks below the
blue viewport as a 1px line; after the fix, it is fully hidden.
- **C — Integer-coordinate control:** the content is fully hidden both
before and after the fix.

| Before | After |
| --- | --- |
| <img width="1658" height="894" alt="native-upstream-before"
src="https://github.com/user-attachments/assets/49943dc9-9f0e-4537-abec-4a03e879c299"
/> | <img width="1658" height="894" alt="native-upstream-after"
src="https://github.com/user-attachments/assets/7c60f959-46fb-4cf9-b43b-bc4b175bd363"
/> |

## Self-review

- [x] I've reviewed my diff for quality, security, reliability, and
performance.
- [x] UI changes follow the
[checklist](https://zed.dev/docs/development/ui-checklist).
- [x] Tests cover the new or changed behavior.

Release Notes:

- [GPUI] Fixed fully clipped content leaking single-pixel lines outside
nested clipping regions.

---------

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
2026-11-18 16:29:18 +00:00
…
2026-11-17 12:43:21 +00:00
…
…
…
…
…

Zed

Zed CI

Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.


Installation

On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).

Other platforms are not yet available:

Developing Zed

Contributing

See CONTRIBUTING.md for ways you can contribute to Zed.

Also... we're hiring! Check out our jobs page for open roles.

Licensing

Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.

License information for third party dependencies must be correctly provided for CI to pass.

We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:

  • Is it showing a no license specified error for a crate you've created? If so, add publish = false under [package] in your crate's Cargo.toml.
  • Is the error failed to satisfy license requirements for a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to the accepted array in script/licenses/zed-licenses.toml.
  • Is cargo-about unable to find the license for a dependency? If so, add a clarification field at the end of script/licenses/zed-licenses.toml, as specified in the cargo-about book.

Sponsorship

Zed is developed by Zed Industries, Inc., a for-profit company.

If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.

S
Description
No description provided
Readme 1.6 GiB
Languages
Rust 95.4%
JSON-with-Comments 2.4%
Python 0.8%
Inno Setup 0.3%
Tree-sitter Query 0.3%
Other 0.4%